From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED20113C8E8; Thu, 12 Jun 2025 10:46:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749725166; cv=none; b=o+GgXwDXDl52kZLhngsO7H3TA0XKUyvtjbQCyAQ6SQzY3/1CX12QsJhNZKCMNuoRwyXUe7BFgbqGalLjN2IxcW+6YaNKil4JxkRun39mAeausFwu3Y14tJcIuZ2BGIYTDSH0JuEXYC7f45rh84LnFuSvn6iK+ZEAXNHnz6EZMGI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749725166; c=relaxed/simple; bh=7yad1GSJQw9Bk8q5ZMOfeOFyJpDchWvUthVVR+3/Fjw=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ok/0rcj1wrw6fZRsd9cST2HUh+cTBbOGDftt0SwRqUbQf0Ffo3HOOEHXhjnufGC5xegmbq78L9+8msMTkn908k9pQI7fNnDWE3o+OrDvaQd73aj4y5llhKOT37XNuHttcvxMcOZgqDsN9Vdq7/uRlaORUl4gFy2PwNKNvDMpJz8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4bHzbl64zPz6L54g; Thu, 12 Jun 2025 18:41:39 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 1B8241402A5; Thu, 12 Jun 2025 18:46:01 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 12 Jun 2025 12:45:59 +0200 Date: Thu, 12 Jun 2025 11:45:57 +0100 From: Jonathan Cameron To: Pavel Machek CC: David Lechner , Michael Hennerich , Lars-Peter Clausen , Jonathan Cameron , Nuno =?UTF-8?Q?S=C3=A1?= , Andy Shevchenko , Matthias Brugger , AngeloGioacchino Del Regno , Heiko Stuebner , Maxime Coquelin , "Alexandre Torgue" , Francesco Dolcini , =?UTF-8?Q?Jo=C3=A3o?= Paulo =?UTF-8?Q?Gon=C3=A7al?= =?UTF-8?Q?ves?= , Leonard =?UTF-8?Q?G?= =?UTF-8?Q?=C3=B6hrs?= , , Oleksij Rempel , Roan van Dijk , Tomasz Duszynski , Jacopo Mondi , Jean-Baptiste Maneyrol , Mudit Sharma , Javier Carrasco , =?UTF-8?Q?Ond=C5=99ej?= Jirman , Andreas Klinger , Petre Rodan , , , , , , Subject: Re: [PATCH 00/28] iio: zero init stack with { } instead of memset() Message-ID: <20250612114557.00007628@huawei.com> In-Reply-To: References: <20250611-iio-zero-init-stack-with-instead-of-memset-v1-0-ebb2d0a24302@baylibre.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100012.china.huawei.com (7.191.174.184) To frapeml500008.china.huawei.com (7.182.85.71) On Thu, 12 Jun 2025 11:17:52 +0200 Pavel Machek wrote: > Hi! > > > Jonathan mentioned recently that he would like to get away from using > > memset() to zero-initialize stack memory in the IIO subsystem. And we > > have it on good authority that initializing a struct or array with = { } > > is the preferred way to do this in the kernel [1]. So here is a series > > to take care of that. > > 1) Is it worth the churn? > > 2) Will this fail to initialize padding with some obscure compiler? > > 3) Why do you believe that {} is the preffered way? All we have is > Kees' email that explains that = {} maybe works in configs he tested. > Pavel, I think main thing that matters in Kees email is there is a self test that should fire if a compiler ever does this wrong. Using this syntax is definitely not a 'kernel wide' preference yet but I do prefer to make some changes like this in IIO just because it reduces the amount of code that smells different when reviewing. Given how many drivers we now have, sadly people pick different ones to cut and paste from so we get a lot of new drivers that look like how we preferred to do things 10 years ago :( However it is a fair bit of churn. hmm. Let's let this sit for a little while and see if other view points come in. Thanks Jonathan > BR, > Pavel > > > [1]: > > https://lore.kernel.org/linux-iio/202505090942.48EBF01B@keescook/ > > > > > --- > > David Lechner (28): > > iio: accel: adxl372: use = { } instead of memset() > > iio: accel: msa311: use = { } instead of memset() > > iio: adc: dln2-adc: use = { } instead of memset() > > iio: adc: mt6360-adc: use = { } instead of memset() > > iio: adc: rockchip_saradc: use = { } instead of memset() > > iio: adc: rtq6056: use = { } instead of memset() > > iio: adc: stm32-adc: use = { } instead of memset() > > iio: adc: ti-ads1015: use = { } instead of memset() > > iio: adc: ti-ads1119: use = { } instead of memset() > > iio: adc: ti-lmp92064: use = { } instead of memset() > > iio: adc: ti-tsc2046: use = { } instead of memset() > > iio: chemical: scd4x: use = { } instead of memset() > > iio: chemical: scd30: use = { } instead of memset() > > iio: chemical: sunrise_co2: use = { } instead of memset() > > iio: dac: ad3552r: use = { } instead of memset() > > iio: imu: inv_icm42600: use = { } instead of memset() > > iio: imu: inv_mpu6050: use = { } instead of memset() > > iio: light: bh1745: use = { } instead of memset() > > iio: light: ltr501: use = { } instead of memset() > > iio: light: opt4060: use = { } instead of memset() > > iio: light: veml6030: use = { } instead of memset() > > iio: magnetometer: af8133j: use = { } instead of memset() > > iio: pressure: bmp280: use = { } instead of memset() > > iio: pressure: mpl3115: use = { } instead of memset() > > iio: pressure: mprls0025pa: use = { } instead of memset() > > iio: pressure: zpa2326: use = { } instead of memset() > > iio: proximity: irsd200: use = { } instead of memset() > > iio: temperature: tmp006: use = { } instead of memset() > > > > drivers/iio/accel/adxl372.c | 3 +-- > > drivers/iio/accel/msa311.c | 4 +--- > > drivers/iio/adc/dln2-adc.c | 4 +--- > > drivers/iio/adc/mt6360-adc.c | 3 +-- > > drivers/iio/adc/rockchip_saradc.c | 4 +--- > > drivers/iio/adc/rtq6056.c | 4 +--- > > drivers/iio/adc/stm32-adc.c | 3 +-- > > drivers/iio/adc/ti-ads1015.c | 4 +--- > > drivers/iio/adc/ti-ads1119.c | 4 +--- > > drivers/iio/adc/ti-lmp92064.c | 4 +--- > > drivers/iio/adc/ti-tsc2046.c | 3 +-- > > drivers/iio/chemical/scd30_core.c | 3 +-- > > drivers/iio/chemical/scd4x.c | 3 +-- > > drivers/iio/chemical/sunrise_co2.c | 6 ++---- > > drivers/iio/dac/ad3552r.c | 3 +-- > > drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c | 5 ++--- > > drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c | 5 ++--- > > drivers/iio/imu/inv_mpu6050/inv_mpu_acpi.c | 4 +--- > > drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c | 6 ++---- > > drivers/iio/light/bh1745.c | 4 +--- > > drivers/iio/light/ltr501.c | 4 +--- > > drivers/iio/light/opt4060.c | 4 +--- > > drivers/iio/light/veml6030.c | 4 +--- > > drivers/iio/magnetometer/af8133j.c | 4 +--- > > drivers/iio/pressure/bmp280-core.c | 5 +---- > > drivers/iio/pressure/mpl3115.c | 3 +-- > > drivers/iio/pressure/mprls0025pa_i2c.c | 5 +---- > > drivers/iio/pressure/zpa2326.c | 4 +--- > > drivers/iio/proximity/irsd200.c | 3 +-- > > drivers/iio/temperature/tmp006.c | 4 +--- > > 30 files changed, 34 insertions(+), 85 deletions(-) > > --- > > base-commit: 4c6073fec2fee4827fa0dd8a4ab4e6f7bbc05ee6 > > change-id: 20250611-iio-zero-init-stack-with-instead-of-memset-0d12d41a7ecb > > > > Best regards, >