From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/5] iio: amplifiers: ada4250: various cleanups
Date: Sat, 14 Jun 2025 13:07:41 +0100 [thread overview]
Message-ID: <20250614130741.22727cac@jic23-huawei> (raw)
In-Reply-To: <aErQ9AM_aZRTr8eH@smile.fi.intel.com>
On Thu, 12 Jun 2025 16:07:00 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Wed, Jun 11, 2025 at 04:33:00PM -0500, David Lechner wrote:
> > While investigating some potential bugs, we noticed quite a few
> > opportunities for small improvements in the ada4250 driver.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> for non-commented patches. Otherwise, feel free to add it there
> if my suggestion / assumptions are wrong.
>
I think, with exception of request for pahole (which is a nice to have
to my eyes rather than a requirement) I think all addressed by David
so applied and tag picked up.
For the pahole thing only thing I can imagine it doing is showing
a less obvious additional move is useful as this one was about as
obvious as they come if IIO_DMA_MINALIGN isn't huge (in which case
it makes no difference as we have a big hole!)
Jonathan
prev parent reply other threads:[~2025-06-14 12:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 21:33 [PATCH v3 0/5] iio: amplifiers: ada4250: various cleanups David Lechner
2025-06-11 21:33 ` [PATCH v3 1/5] iio: amplifiers: ada4250: used dev local variable David Lechner
2025-06-11 21:33 ` [PATCH v3 2/5] iio: amplifiers: ada4250: don't fail on bad chip ID David Lechner
2025-06-11 21:33 ` [PATCH v3 3/5] iio: amplifiers: ada4250: use devm_regulator_get_enable_read_voltage() David Lechner
2025-06-12 13:03 ` Andy Shevchenko
2025-06-12 15:31 ` David Lechner
2025-06-11 21:33 ` [PATCH v3 4/5] iio: amplifiers: ada4250: move offset_uv in struct David Lechner
2025-06-12 13:04 ` Andy Shevchenko
2025-06-12 15:31 ` David Lechner
2025-06-12 18:34 ` Andy Shevchenko
2025-06-12 18:45 ` David Lechner
2025-06-12 18:58 ` Andy Shevchenko
2025-06-11 21:33 ` [PATCH v3 5/5] iio: amplifiers: ada4250: use dev_err_probe() David Lechner
2025-06-12 13:05 ` Andy Shevchenko
2025-06-12 15:33 ` David Lechner
2025-06-12 13:07 ` [PATCH v3 0/5] iio: amplifiers: ada4250: various cleanups Andy Shevchenko
2025-06-14 12:07 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250614130741.22727cac@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox