From: Jonathan Cameron <jic23@kernel.org>
To: "César Bispo" <dm.cesaraugusto@gmail.com>
Cc: jonathan.cameron@huawei.com, cesar.bispo@ime.usp.br,
gabrielfsouza.araujo@usp.br, linux-iio@vger.kernel.org
Subject: Re: [PATCH v1] iio: adc: qcom-pm8xxx-xoadc: Use devm_iio_device_register() and dev_err_probe()
Date: Thu, 26 Jun 2025 19:36:06 +0100 [thread overview]
Message-ID: <20250626193606.50f88b75@jic23-huawei> (raw)
In-Reply-To: <20250625132747.104782-1-cesar.bispo@ime.usp.br>
On Wed, 25 Jun 2025 10:27:27 -0300
"César Bispo" <dm.cesaraugusto@gmail.com> wrote:
> From: Cesar Bispo <cesar.bispo@ime.usp.br>
>
> Hi Jonathan,
>
> Thanks for your feedback.
>
> Just to clarify, the use of `devm_iio_device_register()` in this patch was based on your previous suggestion [1], so I assumed it would be appropriate in this context.
>
> I now understand there might be a risk of userspace-visible interfaces persisting after the device is powered off, which could lead to race conditions.
>
> Would you recommend dropping the `devm_` conversion for now and only keeping the `dev_err_probe()` change?
>
> I'm happy to send a v2 accordingly.
>
> [1] https://lore.kernel.org/linux-iio/20250607163353.47e83e77@jic23-huawei/
I was suggesting the use of devm_iio_device_register() 'on top' of the changes
in that patch. My confusion here is that you've sent out code based on the
tree before that patch and hence the regulator handling is still manual.
Looking again at that patch it has a bug. Replied there and dropped that patch.
Jonathan
prev parent reply other threads:[~2025-06-26 18:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 2:33 [PATCH v1] iio: adc: Use devm_iio_device_register() and dev_err_probe() César Bispo
2025-06-25 9:11 ` Jonathan Cameron
2025-06-25 13:27 ` [PATCH v1] iio: adc: qcom-pm8xxx-xoadc: " César Bispo
2025-06-26 18:36 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250626193606.50f88b75@jic23-huawei \
--to=jic23@kernel.org \
--cc=cesar.bispo@ime.usp.br \
--cc=dm.cesaraugusto@gmail.com \
--cc=gabrielfsouza.araujo@usp.br \
--cc=jonathan.cameron@huawei.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox