From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Saravanan Sekar" <sravanhome@gmail.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: mp2629_adc: make mp2629_channels const
Date: Sun, 29 Jun 2025 17:55:33 +0100 [thread overview]
Message-ID: <20250629175533.784fa929@jic23-huawei> (raw)
In-Reply-To: <20250628-iio-const-data-8-v1-1-32ce79494d4a@baylibre.com>
On Sat, 28 Jun 2025 11:31:02 -0500
David Lechner <dlechner@baylibre.com> wrote:
> Add const qualifier to struct iio_chan_spec mp2629_channels[]. This
> is read-only data so it can be made const.
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
Applied to the testing branch of iio.git. If anyone has comments
there is still time before I push this out as the non rebasing togreg
branch.
Mostly I assume that if David and I miss somethiing on these the
compiler will scream either in my local tests of when 0-day hits the
testing tree tomorrow.
> ---
> drivers/iio/adc/mp2629_adc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/mp2629_adc.c b/drivers/iio/adc/mp2629_adc.c
> index 1cb043b17437780970ce355f9d93fd36cbd26826..5a1d516f8dad8e2cf46a43e1a40d1cc7adaecc13 100644
> --- a/drivers/iio/adc/mp2629_adc.c
> +++ b/drivers/iio/adc/mp2629_adc.c
> @@ -44,7 +44,7 @@ struct mp2629_adc {
> struct device *dev;
> };
>
> -static struct iio_chan_spec mp2629_channels[] = {
> +static const struct iio_chan_spec mp2629_channels[] = {
> MP2629_ADC_CHAN(BATT_VOLT, IIO_VOLTAGE),
> MP2629_ADC_CHAN(SYSTEM_VOLT, IIO_VOLTAGE),
> MP2629_ADC_CHAN(INPUT_VOLT, IIO_VOLTAGE),
>
> ---
> base-commit: 14071b9cf2d751ff9bc8b5e43fa94fbf08aceea1
> change-id: 20250628-iio-const-data-8-8c8921ee3b3f
>
> Best regards,
prev parent reply other threads:[~2025-06-29 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-28 16:31 [PATCH] iio: adc: mp2629_adc: make mp2629_channels const David Lechner
2025-06-29 16:55 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250629175533.784fa929@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sravanhome@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox