Re: iio: accel: sca3000: dead code issue

[Jonathan Cameron <Jonathan.Cameron@huawei.com>]

On Wed, 2 Jul 2025 15:11:26 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Wed, Jul 02, 2025 at 10:00:55AM +0100, Colin King (gmail) wrote:
> 
> >                 ret = spi_w8r8(st->us,
> > SCA3000_READ_REG(SCA3000_REG_BUF_COUNT_ADDR));
> >   
> > >>>  the call to spi_w8r8 returns 0 on success or -ve on an error  
> 
> Where did you get this from, please?  Any link to elixir or Git repo?
> 

Hmm.  Just for reference the docs of spi_w8r8 are:

* Return: the (unsigned) eight bit number returned by the
* device, or else a negative error code.

Not 0 on success (well not unless it is zero.

So the check indeed looks wrong as should be if (ret < 0)


https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=testing&id=ca66d8208762492df8442a503db568d9aab65f2f
It's in my tree.

I'll drop the patch when I'm on the right machine.  Andrew, could
you do a new version fixing this up?  If not can make the changes
but will be at least the weekend before I get a chance.

Looks like there are a couple of instances of this.

Jonathan



> > 
> >                 if (ret)
> >                         goto error_ret;  
>