From: Jonathan Cameron <jic23@kernel.org>
To: Andrew Ijano <andrew.ijano@gmail.com>
Cc: andrew.lopes@alumni.usp.br, gustavobastos@usp.br,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
jstephan@baylibre.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/4] iio: accel: sca3000: use lock guards
Date: Sun, 6 Jul 2025 10:37:08 +0100 [thread overview]
Message-ID: <20250706103708.65de7569@jic23-huawei> (raw)
In-Reply-To: <CANZih_Tm2w5C58tg36LzEMoLrqWgSGaJZQ_nxoDVUXFMJnZBXQ@mail.gmail.com>
> > > - ret = sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR,
> > > + return sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR,
> > This adds a character to this line which means that either the indent of
> > the following lines was previously wrong, or it is now.
> > I think you need to add a space to the following lines.
> >
> > Check for other similar cases.
> >
> > > ret &
> > > ~(SCA3000_REG_INT_MASK_RING_THREE_QUARTER |
> > > SCA3000_REG_INT_MASK_RING_HALF |
> > > SCA3000_REG_INT_MASK_ALL_INTS));
>
> Hm, correct me if I'm mistaken but I couldn't find this extra
> character, I used the same number of tabs in both cases. Even in this
> email it shows as having the same number of white spaces.
return sca3000_write_reg(
is one character longer than
ret = sca3000_write_reg(
and seeing as parameters on later lines should align just after this they all
need one additional space.
>
> Thanks,
> Andrew
next prev parent reply other threads:[~2025-07-06 9:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 3:12 [PATCH v6 0/4] iio: accel: sca3000: simplify by using newer infrastructure Andrew Ijano
2025-06-18 3:12 ` [PATCH v6 1/4] iio: accel: sca3000: replace usages of internal read data helpers by spi helpers Andrew Ijano
2025-06-21 17:38 ` Jonathan Cameron
2025-07-05 3:17 ` Andrew Ijano
2025-06-18 3:12 ` [PATCH v6 2/4] iio: accel: sca3000: clean sca3000_read_data() Andrew Ijano
2025-06-21 17:40 ` Jonathan Cameron
2025-06-18 3:12 ` [PATCH v6 3/4] iio: accel: sca3000: use lock guards Andrew Ijano
2025-06-21 17:55 ` Jonathan Cameron
2025-07-05 3:37 ` Andrew Ijano
2025-07-06 9:37 ` Jonathan Cameron [this message]
2025-06-18 3:12 ` [PATCH v6 4/4] iio: accel: sca3000: use sysfs_emit_at() instead of sprintf() Andrew Ijano
2025-06-21 17:58 ` Jonathan Cameron
2025-07-05 3:45 ` Andrew Ijano
2025-07-06 9:41 ` Jonathan Cameron
2025-06-18 5:55 ` [PATCH v6 0/4] iio: accel: sca3000: simplify by using newer infrastructure Andy Shevchenko
2025-06-18 12:24 ` Andrew Ijano
2025-06-18 17:41 ` Andy Shevchenko
2025-06-18 18:20 ` Andrew Ijano
2025-06-19 15:23 ` Andy Shevchenko
2025-07-05 3:03 ` Andrew Ijano
2025-07-05 18:18 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250706103708.65de7569@jic23-huawei \
--to=jic23@kernel.org \
--cc=andrew.ijano@gmail.com \
--cc=andrew.lopes@alumni.usp.br \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gustavobastos@usp.br \
--cc=jstephan@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox