Re: [PATCH v3 2/3] dt-bindings: iio: proximity: Add Nicera D3-323-AA PIR sensor

[Jonathan Cameron <jic23@kernel.org>]

On Fri, 4 Jul 2025 18:14:38 +0200
Waqar Hameed <waqar.hameed@axis.com> wrote:

> Nicera D3-323-AA is a PIR sensor for human detection. It has two GPIOs
> for detection and data communication.
> 
> Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
> ---
>  .../iio/proximity/nicera,d3323aa.yaml         | 62 +++++++++++++++++++
>  1 file changed, 62 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/proximity/nicera,d3323aa.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/proximity/nicera,d3323aa.yaml b/Documentation/devicetree/bindings/iio/proximity/nicera,d3323aa.yaml
> new file mode 100644
> index 000000000000..65d9b44fcd5e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/proximity/nicera,d3323aa.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/proximity/nicera,d3323aa.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nicera D3-323-AA PIR sensor
> +
> +maintainers:
> +  - Waqar Hameed <waqar.hameed@axis.com>
> +
> +description: |
> +  PIR sensor for human detection.
> +  Datasheet: https://www.endrich.com/Datenbl%C3%A4tter/Sensoren/D3-323-AA_e.pdf
> +
> +properties:
> +  compatible:
> +    const: nicera,d3323aa
> +
> +  vdd-supply:
> +    description:
> +      Supply voltage (1.8 to 5.5 V).
> +
> +  vout-clk-gpios:
> +    maxItems: 1
> +    description:
> +      GPIO for clock and detection.
> +      After reset, the device signals with two falling edges on this pin that it
> +      is ready for configuration (within 1.2 s).
> +      During configuration, it is used as clock for data reading and writing (on
> +      data-gpios).
> +      After all this, when device is in operational mode, it signals on this pin
> +      for any detections.

Don't start a new line for a new sentence. 

> +
> +  data-gpios:
> +    maxItems: 1
> +    description:
> +      GPIO for data reading and writing. This is denoted "DO (SI)" in datasheet.
> +      During configuration, this pin is used for writing and reading
> +      configuration data (together with vout-clk-gpios as clock).
> +      After this, during operational mode, the device will output serial data on
> +      this GPIO.
> +
> +required:
> +  - compatible
> +  - vdd-supply
> +  - vout-clk-gpios
> +  - data-gpios
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    proximity {
> +        compatible = "nicera,d3323aa";
> +        vdd-supply = <&regulator_3v3>;
> +        vout-clk-gpios = <&gpio 78 GPIO_ACTIVE_HIGH>;
> +        data-gpios = <&gpio 76 GPIO_ACTIVE_HIGH>;
> +    };
> +...