Re: [PATCH] iio: proximity: sx9500: use stack allocated buffer for scan data

[Jonathan Cameron <jic23@kernel.org>]

On Sun, 13 Jul 2025 11:47:56 -0500
David Lechner <dlechner@baylibre.com> wrote:

> On 7/13/25 8:58 AM, Jonathan Cameron wrote:
> > On Sun, 13 Jul 2025 14:55:33 +0100
> > Jonathan Cameron <jic23@kernel.org> wrote:
> >   
> >> On Fri, 11 Jul 2025 19:42:25 +0300
> >> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> >>  
> >>> On Fri, Jul 11, 2025 at 10:47:57AM -0500, David Lechner wrote:    
> >>>> Use IIO_DECLARE_BUFFER_WITH_TS() to declare a stack allocated buffer
> >>>> in sx9500_trigger_handler(). Since the scan buffer isn't used outside
> >>>> of this function, it doesn't need to be in struct sx9500_data.
> >>>>
> >>>> By always allocating enough space for the maximum number of channels,
> >>>> we can avoid having to reallocate the buffer each time buffered reads
> >>>> are enabled.      
> >>>
> >>> Ag ood one!
> >>>
> >>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >>>     
> >>
> >> Applied.
> >>  
> > 
> > Actually on second thoughts - why not a more descriptive structure?
> > There are only a max of 4 channels and so the timestamp is always
> > in the same location.
> > 
> > Dropped for now.
> > 
> > Jonathan  
> 
> I didn't do that on this one since a variable number of scan
> elements are used. But if you prefer structs for anything up
> to 8 bytes, we can go with that.
I think that makes sense as we don't really care 'what' is in the
holes when fewer channels are enabled.

Jonathan