From: Greg KH <gregkh@linuxfoundation.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: sboyd@kernel.org, jic23@kernel.org, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, arnd@arndb.de,
srini@kernel.org, vkoul@kernel.org, kishon@kernel.org,
sre@kernel.org, krzysztof.kozlowski@linaro.org,
u.kleine-koenig@baylibre.com, linux-arm-msm@vger.kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-phy@lists.infradead.org, linux-pm@vger.kernel.org,
kernel@collabora.com, wenst@chromium.org
Subject: Re: [PATCH v1 5/7] misc: qcom-coincell: Migrate to devm_spmi_subdevice_alloc_and_add()
Date: Mon, 21 Jul 2025 10:58:27 +0200 [thread overview]
Message-ID: <2025072120-swaddling-fencing-3dc0@gregkh> (raw)
In-Reply-To: <20250721075525.29636-6-angelogioacchino.delregno@collabora.com>
On Mon, Jul 21, 2025 at 09:55:23AM +0200, AngeloGioacchino Del Regno wrote:
> Some Qualcomm PMICs integrate a charger for coincells, usually
> powering an RTC when external (or main battery) power is missing.
>
> Instead of using the parent SPMI device (the main PMIC) as a kind
> of syscon in this driver, register a new SPMI sub-device and
> initialize its own regmap with this sub-device's specific base
> address, retrieved from the devicetree.
>
> This allows to stop manually adding the register base address to
> every R/W call in this driver, as this can be, and is now, handled
> by the regmap API instead.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/misc/qcom-coincell.c | 37 ++++++++++++++++++++++++++----------
> 1 file changed, 27 insertions(+), 10 deletions(-)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2025-07-21 8:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 7:55 [PATCH v1 0/7] SPMI: Implement sub-devices and migrate drivers AngeloGioacchino Del Regno
2025-07-21 7:55 ` [PATCH v1 1/7] spmi: Implement spmi_subdevice_alloc_and_add() and devm variant AngeloGioacchino Del Regno
2025-07-21 11:34 ` Andy Shevchenko
2025-07-21 13:00 ` AngeloGioacchino Del Regno
2025-07-21 7:55 ` [PATCH v1 2/7] nvmem: qcom-spmi-sdam: Migrate to devm_spmi_subdevice_alloc_and_add() AngeloGioacchino Del Regno
2025-07-21 10:44 ` Casey Connolly
2025-07-21 12:45 ` AngeloGioacchino Del Regno
2025-07-21 13:56 ` Casey Connolly
2025-07-22 8:21 ` AngeloGioacchino Del Regno
2025-07-21 7:55 ` [PATCH v1 3/7] power: reset: qcom-pon: " AngeloGioacchino Del Regno
2025-07-21 11:36 ` Andy Shevchenko
2025-07-21 13:05 ` AngeloGioacchino Del Regno
2025-07-21 17:14 ` Andy Shevchenko
2025-07-22 8:23 ` AngeloGioacchino Del Regno
2025-07-21 7:55 ` [PATCH v1 4/7] phy: qualcomm: eusb2-repeater: " AngeloGioacchino Del Regno
2025-07-21 13:10 ` kernel test robot
2025-07-21 18:27 ` kernel test robot
2025-07-21 7:55 ` [PATCH v1 5/7] misc: qcom-coincell: " AngeloGioacchino Del Regno
2025-07-21 8:58 ` Greg KH [this message]
2025-07-21 11:30 ` kernel test robot
2025-07-21 7:55 ` [PATCH v1 6/7] iio: adc: qcom-spmi-iadc: " AngeloGioacchino Del Regno
2025-07-21 7:55 ` [PATCH v1 7/7] iio: adc: qcom-spmi-iadc: Remove regmap R/W wrapper functions AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025072120-swaddling-fencing-3dc0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kernel@collabora.com \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sboyd@kernel.org \
--cc=sre@kernel.org \
--cc=srini@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
--cc=vkoul@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).