From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Gustavo Silva" <gustavograzs@gmail.com>,
"Alex Lanzano" <lanzano.alex@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Lothar Rubusch" <l.rubusch@gmail.com>
Subject: Re: [PATCH v4 3/3] iio: imu: bmi270: add support for motion events
Date: Thu, 24 Jul 2025 16:28:10 +0100 [thread overview]
Message-ID: <20250724162810.214414fe@jic23-huawei> (raw)
In-Reply-To: <aHd1qDR3jNTKBbun@smile.fi.intel.com>
On Wed, 16 Jul 2025 12:49:28 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Tue, Jul 15, 2025 at 08:52:41PM -0300, Gustavo Silva wrote:
> > On Tue, Jul 15, 2025 at 10:37:21AM +0300, Andy Shevchenko wrote:
> > > On Fri, Jul 11, 2025 at 08:36:03PM -0300, Gustavo Silva wrote:
>
> ...
>
> > > Is this already documented in ABI?
> > >
> > Not yet. Should this have a device-specific ABI entry?
>
> I don't know, but what I can say is that change is no-go without documented ABI.
>
Indeed. Seems this particular combination has yet shown up (or we missed
it for docs). Add appropriate events/in_accel_value_available
entry to Documentation/ABI/sysfs-bus-iio
Whilst you are there, good to check that all the other ABI for this device
is listed in there. Given we mostly construct ABI from a bunch of parts, it
is easy to miss entries for particular combinations of channel type and thing.
Jonathan
prev parent reply other threads:[~2025-07-24 15:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250711-bmi270-events-v4-0-53ec7da35046@gmail.com>
2025-07-11 23:36 ` [PATCH v4 3/3] iio: imu: bmi270: add support for motion events Gustavo Silva
2025-07-15 7:37 ` Andy Shevchenko
2025-07-15 7:49 ` Andy Shevchenko
2025-07-15 23:55 ` Gustavo Silva
2025-07-16 9:53 ` Andy Shevchenko
2025-07-24 15:22 ` Jonathan Cameron
2025-07-24 21:26 ` Andy Shevchenko
2025-07-27 15:49 ` Jonathan Cameron
2025-08-02 11:58 ` Jonathan Cameron
2025-08-04 22:26 ` Gustavo Silva
2025-08-10 18:25 ` Jonathan Cameron
2025-07-15 23:52 ` Gustavo Silva
2025-07-16 9:49 ` Andy Shevchenko
2025-07-24 15:28 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250724162810.214414fe@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gustavograzs@gmail.com \
--cc=l.rubusch@gmail.com \
--cc=lanzano.alex@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).