Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] iio: adc: ad7137: add filter support
Date: Sun, 27 Jul 2025 16:39:58 +0100	[thread overview]
Message-ID: <20250727163958.1ed6e764@jic23-huawei> (raw)
In-Reply-To: <fe3f5832-469b-4d8b-9d02-ea716c07c5d9@baylibre.com>

On Thu, 24 Jul 2025 13:50:01 -0500
David Lechner <dlechner@baylibre.com> wrote:

> On 7/24/25 8:20 AM, Jonathan Cameron wrote:
> > On Thu, 10 Jul 2025 17:47:14 -0500
> > David Lechner <dlechner@baylibre.com> wrote:
> >   
> >> On 7/10/25 5:39 PM, David Lechner wrote:  
> >>> Adding yet another feature to the ad7173 driver, this time,
> >>> filter support.
> >>>
> >>> There are a couple of leading patches to rename some stuff to minimize
> >>> the diff in the main patch where filter support is actually added. And
> >>> there is a bonus patch to clean up the ABI docs for filter_type first
> >>> before adding the new filter types introduced in this series.
> >>>
> >>> This was tested on the EVAL-AD7173-8ARDZ evaluation board.
> >>>
> >>> This series depends on a bunch of fixes, so we'll have to wait for
> >>> those to make it back into iio/testing before we can merge this
> >>> series. There is also an outstanding patch to add SPI offload support
> >>> to this driver, but that doesn't actually have any merge conflicts
> >>> with this series, so they can be applied in any order.
> >>>
> >>> ---
> >>> David Lechner (5):
> >>>       iio: adc: ad7173: rename ad7173_chan_spec_ext_info
> >>>       iio: adc: ad7173: rename odr field
> >>>       iio: adc: ad7173: support changing filter type
> >>>       iio: ABI: alphabetize filter types
> >>>       iio: ABI: add filter types for ad7173
> >>>     
> >> I don't know why, but I really struggle to write this part number
> >> correctly. The subject of this cover letter is wrong, but at least
> >> I got it right in all of the patch subject lines.
> >>  
> > 
> > Series look good to me. Give me a poke if it looks like I've forgotten
> > to pick this up after the precursor fix is in my tree.
> > 
> > Jonathan  
> 
> Sure, no problem. Can we pick up PATCH 4/5 ("iio: ABI: alphabetize
> filter types") sooner though? I know there is at least one other
> series under review that is adding more filter types and I am
> getting ready to start on another one that will likely introduce
> some more variants.
> 
Sure.  Patch 4 applied to the testing branch of iio.git.

Thanks,

Jonathan



  reply	other threads:[~2025-07-27 15:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-10 22:39 [PATCH 0/5] iio: adc: ad7137: add filter support David Lechner
2025-07-10 22:39 ` [PATCH 1/5] iio: adc: ad7173: rename ad7173_chan_spec_ext_info David Lechner
2025-07-10 22:39 ` [PATCH 2/5] iio: adc: ad7173: rename odr field David Lechner
2025-07-24 13:15   ` Jonathan Cameron
2025-07-10 22:39 ` [PATCH 3/5] iio: adc: ad7173: support changing filter type David Lechner
2025-07-25  8:44   ` Nuno Sá
2025-07-10 22:39 ` [PATCH 4/5] iio: ABI: alphabetize filter types David Lechner
2025-07-10 22:39 ` [PATCH 5/5] iio: ABI: add filter types for ad7173 David Lechner
2025-07-10 22:47 ` [PATCH 0/5] iio: adc: ad7137: add filter support David Lechner
2025-07-24 13:20   ` Jonathan Cameron
2025-07-24 18:50     ` David Lechner
2025-07-27 15:39       ` Jonathan Cameron [this message]
2025-07-25  8:47   ` Nuno Sá

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250727163958.1ed6e764@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox