From: Ben Collins <bcollins@kernel.org>
To: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Ben Collins <bcollins@kernel.org>
Subject: [PATCH v7 2/5] ABI: sysfs-bus-iio: Disambiguate usage for filter_type "none"
Date: Mon, 25 Aug 2025 20:10:04 -0400 [thread overview]
Message-ID: <20250825-mcp9600-iir-v7-2-2ba676a52589@kernel.org> (raw)
In-Reply-To: <20250825-mcp9600-iir-v7-0-2ba676a52589@kernel.org>
When a filter_type is "none", there really is no useful information that
can be presented from sampling and frequency attributes.
This is especially true when the driver supports more than one
filter_type, since the information would be ambiguous.
Suggest returning IIO_VAL_EMPTY for this case.
Signed-off-by: Ben Collins <bcollins@kernel.org>
---
Documentation/ABI/testing/sysfs-bus-iio | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
index 7e31b8cd49b32ea5b58bd99afc2e8105314d7a39..df42a4040530ee96096b998bebc8a08b4fb2d78f 100644
--- a/Documentation/ABI/testing/sysfs-bus-iio
+++ b/Documentation/ABI/testing/sysfs-bus-iio
@@ -2276,7 +2276,11 @@ Description:
Reading returns a list with the possible filter modes. Options
for the attribute:
- * "none" - Filter is disabled/bypassed.
+ * "none" - Filter is disabled/bypassed. When set in the
+ filter_type attribute, a driver should return IIO_VAL_EMPTY
+ when reading sampling and frequency related attributes of
+ this filter, and return -EINVAL when trying to write these
+ attributes.
* "sinc1" - The digital sinc1 filter. Fast 1st
conversion time. Poor noise performance.
* "sinc3" - The digital sinc3 filter. Moderate 1st
--
2.39.5
next prev parent reply other threads:[~2025-08-26 0:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 0:10 [PATCH v7 0/5] iio: mcp9600: Implement IIR feature and add iio core support Ben Collins
2025-08-26 0:10 ` [PATCH v7 1/5] iio: core: Add IIO_VAL_EMPTY type Ben Collins
2025-08-26 17:00 ` David Lechner
2025-08-26 18:52 ` Ben Collins
2025-08-31 15:19 ` Jonathan Cameron
2025-08-26 0:10 ` Ben Collins [this message]
2025-08-26 0:10 ` [PATCH v7 3/5] ABI: sysfs-bus-iio: Document "ema" filter_type Ben Collins
2025-08-26 0:10 ` [PATCH v7 4/5] iio: mcp9600: Add support for IIR filter Ben Collins
2025-08-26 17:20 ` David Lechner
2025-08-26 19:08 ` Ben Collins
2025-08-26 0:10 ` [PATCH v7 5/5] iio: ad4080: Rework filter_type "none" logic Ben Collins
2025-08-26 16:51 ` David Lechner
2025-08-26 19:11 ` Ben Collins
2025-08-31 15:25 ` Jonathan Cameron
2025-08-26 8:14 ` [PATCH v7 0/5] iio: mcp9600: Implement IIR feature and add iio core support Andy Shevchenko
2025-08-26 9:38 ` Ben Collins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250825-mcp9600-iir-v7-2-2ba676a52589@kernel.org \
--to=bcollins@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).