From: Jonathan Cameron <jic23@kernel.org>
To: Gustavo Silva <gustavograzs@gmail.com>
Cc: "Xichao Zhao" <zhao.xichao@vivo.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Tomasz Duszynski" <tomasz.duszynski@octakon.com>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/7] iio: chemical: Remove dev_err_probe() if error is -ENOMEM
Date: Mon, 25 Aug 2025 09:37:33 +0100 [thread overview]
Message-ID: <20250825093733.789cfc12@jic23-huawei> (raw)
In-Reply-To: <y3pmdf6swvsqltu3imitrcietjybbwtmewjmmk326o4oqzadh4@pyxfp3czft2n>
On Sat, 23 Aug 2025 14:27:55 -0300
Gustavo Silva <gustavograzs@gmail.com> wrote:
> On Thu, Aug 21, 2025 at 04:06:47PM +0800, Xichao Zhao wrote:
> > The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
> > Therefore, remove the useless call to dev_err_probe(), and just
> > return the value instead.
> >
> > Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
> > ---
> > drivers/iio/chemical/ens160_core.c | 3 +--
> > drivers/iio/chemical/scd30_core.c | 2 +-
> > 2 files changed, 2 insertions(+), 3 deletions(-)
> For ens160:
> Reviewed-by: Gustavo Silva <gustavograzs@gmail.com>
Please use
Reviewed-by: Gustavo Silva <gustavograzs@gmail.com> # for ens160
for commented tags. Then tooling should pick them up correctly
without me needing to hand edit.
Thanks,
Jonathan
next prev parent reply other threads:[~2025-08-25 8:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 8:06 [PATCH 0/7] iio: Remove dev_err_probe() if error is -ENOMEM Xichao Zhao
2025-08-21 8:06 ` [PATCH 1/7] iio: accel: msa311: " Xichao Zhao
2025-08-21 8:06 ` [PATCH 2/7] iio: adc: " Xichao Zhao
2025-08-21 20:31 ` Martin Blumenstingl
2025-08-25 8:36 ` Jonathan Cameron
2025-08-21 8:06 ` [PATCH 3/7] iio: chemical: " Xichao Zhao
2025-08-23 17:27 ` Gustavo Silva
2025-08-25 8:37 ` Jonathan Cameron [this message]
2025-08-21 8:06 ` [PATCH 4/7] iio: imu: bmi323: " Xichao Zhao
2025-08-21 8:06 ` [PATCH 5/7] iio: light: " Xichao Zhao
2025-08-21 8:06 ` [PATCH 6/7] iio: proximity: " Xichao Zhao
2025-08-21 8:06 ` [PATCH 7/7] iio: temperature: mlx90635: " Xichao Zhao
2025-08-21 11:46 ` Crt Mori
2025-08-21 12:46 ` Andy Shevchenko
2025-08-21 14:00 ` Crt Mori
2025-08-21 8:13 ` [PATCH 0/7] iio: " Andy Shevchenko
2025-08-21 11:50 ` Crt Mori
2025-08-21 12:47 ` Andy Shevchenko
2025-08-25 8:41 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250825093733.789cfc12@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gustavograzs@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=tomasz.duszynski@octakon.com \
--cc=zhao.xichao@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox