Re: [PATCH v1 1/2] dt-bindings: iio: adc: Add device tree binding for MAX22531 ADC

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2094 bytes --]

On Tue, Aug 26, 2025 at 02:55:24AM +0530, Abhinav Jain wrote:
> Add device tree documentation for MAX22530-MAX22532 family of ADCs.
> The MAX22530–MAX22532 are galvanically isolated, 4-channel, multiplexed,
> 12-bit, analog-to-digital converters (ADC) in the MAXSafe™ family product
> line. An integrated, isolated, DC-DC converter powers all fieldside
> circuitry, and this allows field-side diagnostics even when no input
> signal is present.
> 
> Signed-off-by: Abhinav Jain <jain.abhinav177@gmail.com>
> ---
>  .../bindings/iio/adc/adi,max22531.yaml        | 75 +++++++++++++++++++
>  MAINTAINERS                                   |  7 ++
>  2 files changed, 82 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,max22531.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,max22531.yaml b/Documentation/devicetree/bindings/iio/adc/adi,max22531.yaml
> new file mode 100644
> index 000000000000..16bf4a1d0926
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,max22531.yaml
> @@ -0,0 +1,75 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright 2025 Abhinav Jain
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/adi,max22531.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices MAX22530-MAX22532 12-bit Field Isolated ADCs
> +
> +maintainers:
> +  - Abhinav Jain <jain.abhinav177@gmail.com>
> +
> +description:
> +  Bindings for the Analog Devices Max22530-MAX22532 Field-Side Self-Powered,
> +  4-Channel, 12-bit, Isolated ADCs.
> +
> +  Datasheet can be found here
> +    https://www.analog.com/media/en/technical-documentation/data-sheets/max22530-max22532.pdf
> +
> +$ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - adi,max22530
> +      - adi,max22531
> +      - adi,max22532

Generally this looks okay to me, but I would like you to mention what it
is that makes a fallback between these impossible in your commit
message. 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]