From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Andreas Klinger" <ak@it-klinger.de>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: proximity: mb1232: use stack allocated scan struct
Date: Sun, 7 Sep 2025 14:29:25 +0100 [thread overview]
Message-ID: <20250907142925.6008a5cc@jic23-huawei> (raw)
In-Reply-To: <fb550af2-37e0-40f2-a44b-52962337cea5@baylibre.com>
On Fri, 5 Sep 2025 14:12:49 -0500
David Lechner <dlechner@baylibre.com> wrote:
> On 7/24/25 5:26 AM, Jonathan Cameron wrote:
> > On Tue, 22 Jul 2025 17:39:17 -0500
> > David Lechner <dlechner@baylibre.com> wrote:
> >
> >> Use a stack allocated struct for the scan data instead of using the
> >> driver state to store the struct. The scan data is not used outside of
> >> the interrupt handler function so the struct does not need to exist
> >> outside of that scope.
> >>
> >> Signed-off-by: David Lechner <dlechner@baylibre.com>
> > Hi David,
> >
> > Applied to the testing branch of iio.git.
> >
> > I don't suppose you fancy a follow up to take that irqnr local to probe?
> > If not I'll get to it at some point maybe.
> >
> It is also used in mb1232_read_distance(), so this wouldn't be trivial.
Ah. I'd missed that. Agreed that it doesn't makes sense to make it
local.
J
prev parent reply other threads:[~2025-09-07 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 22:39 [PATCH] iio: proximity: mb1232: use stack allocated scan struct David Lechner
2025-07-24 10:26 ` Jonathan Cameron
2025-09-05 19:12 ` David Lechner
2025-09-07 13:29 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250907142925.6008a5cc@jic23-huawei \
--to=jic23@kernel.org \
--cc=ak@it-klinger.de \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox