From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>
Subject: Re: [PATCH 0/7] iio: buffer: document calling context when pushing to buffers
Date: Sat, 13 Sep 2025 14:57:09 +0100 [thread overview]
Message-ID: <20250913145709.7950f975@jic23-huawei> (raw)
In-Reply-To: <20250912-iio-doc-push-to-buffers-context-v1-0-c4aad013d96e@baylibre.com>
On Fri, 12 Sep 2025 11:05:51 -0500
David Lechner <dlechner@baylibre.com> wrote:
> It came up in a recent discussion [1] that we need to be careful about
> the calling context for various iio_push_to_buffer*() functions. Here is
> a series that adds some documentation in a number of places to make this
> a bit more visible.
>
> [1]: https://lore.kernel.org/linux-iio/CAHp75Vc8u2N2AHWtnPRmRXWKN3u8Qi=yvx5afbFh4NLNb8-y9A@mail.gmail.com/
>
> ---
> David Lechner (7):
> iio: buffer: document iio_push_to_buffers_with_ts_unaligned() may sleep
> iio: buffer: iio_push_to_buffers_with_ts_unaligned() might_sleep()
> iio: buffer: document iio_push_to_buffers_with_ts()
> iio: buffer: deprecated iio_push_to_buffers_with_timestamp()
> iio: buffer: document iio_push_to_buffers() calling context
> iio: buffer: document store_to() callback may be called in any context
> iio: buffer: document that buffer callback must be context safe
>
> drivers/iio/buffer/industrialio-buffer-cb.c | 1 +
> drivers/iio/industrialio-buffer.c | 8 ++++++++
> include/linux/iio/buffer.h | 22 +++++++++++++++++-----
> include/linux/iio/buffer_impl.h | 3 ++-
> include/linux/iio/consumer.h | 3 ++-
> 5 files changed, 30 insertions(+), 7 deletions(-)
> ---
> base-commit: b8902d55155cec7bd743dc1129e0b32e70b1751f
> change-id: 20250912-iio-doc-push-to-buffers-context-df3ca98fe0df
>
> Best regards,
Whilst this is very nearly good to go (assuming the might_sleep() discussion
is done), I'm going to be lazy and ask for a v2 to resolve that DEPRECATED
comment style thing and the tiny change I asked for.
Thanks for doing this and I'm a bit embarrassed that I didn't document
the with_ts() function when introducing it :(
Jonathan
prev parent reply other threads:[~2025-09-13 13:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 16:05 [PATCH 0/7] iio: buffer: document calling context when pushing to buffers David Lechner
2025-09-12 16:05 ` [PATCH 1/7] iio: buffer: document iio_push_to_buffers_with_ts_unaligned() may sleep David Lechner
2025-09-12 18:12 ` Andy Shevchenko
2025-09-12 16:05 ` [PATCH 2/7] iio: buffer: iio_push_to_buffers_with_ts_unaligned() might_sleep() David Lechner
2025-09-12 18:10 ` Andy Shevchenko
2025-09-12 18:40 ` David Lechner
2025-09-13 13:52 ` Jonathan Cameron
2025-09-12 16:05 ` [PATCH 3/7] iio: buffer: document iio_push_to_buffers_with_ts() David Lechner
2025-09-13 13:54 ` Jonathan Cameron
2025-09-12 16:05 ` [PATCH 4/7] iio: buffer: deprecated iio_push_to_buffers_with_timestamp() David Lechner
2025-09-12 18:11 ` Andy Shevchenko
2025-09-12 16:05 ` [PATCH 5/7] iio: buffer: document iio_push_to_buffers() calling context David Lechner
2025-09-12 16:05 ` [PATCH 6/7] iio: buffer: document store_to() callback may be called in any context David Lechner
2025-09-12 16:05 ` [PATCH 7/7] iio: buffer: document that buffer callback must be context safe David Lechner
2025-09-13 13:57 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250913145709.7950f975@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox