Re: [PATCH 0/9] iio: replace sprintf() with sysfs_emit() in .read_label() op

[Jonathan Cameron <jic23@kernel.org>]

On Tue, 30 Sep 2025 16:33:09 +0100
Nuno Sá via B4 Relay <devnull+nuno.sa.analog.com@kernel.org> wrote:

> When looking at some drivers implementing the .read_label() callback it
> came to my attention that there were some outliers using sprintf() (or
> even snprintf() with PAGE_SIZE) instead of sysfs_emit(). This series
> cleans that up. 

I hope this doesn't come back to bite us by a future in kernel consumer not
directly spitting the result of this into a sysfs read buffer.  Anyhow
today it's fine and we have existing cases doing sysfs_emit() so arguably
any future problems aren't made worse by this patch set + for common usage
it's an improvement.

So applied.

Thanks,

Jonathan

> 
> ---
> Nuno Sá (9):
>       iio: adc: ad4030: replace sprintf() with sysfs_emit()
>       iio: adc: ad7768-1: replace sprintf() with sysfs_emit()
>       iio: adc: mcp3564: replace sprintf() with sysfs_emit()
>       iio: adc: meson_saradc: replace sprintf() with sysfs_emit()
>       iio: adc: mt6360-adc: replace snprintf() with sysfs_emit()
>       iio: adc: pac1921: replace sprintf() with sysfs_emit()
>       iio: adc: qcom-spmi-rradc: replace snprintf() with sysfs_emit()
>       iio: position: hid-sensor-custom-intel-hinge: replace sprintf() with sysfs_emit()
>       iio: resolver: ad2s1210: replace sprintf() with sysfs_emit()
> 
>  drivers/iio/adc/ad4030.c                           |  4 +--
>  drivers/iio/adc/ad7768-1.c                         |  2 +-
>  drivers/iio/adc/mcp3564.c                          |  2 +-
>  drivers/iio/adc/meson_saradc.c                     |  6 ++---
>  drivers/iio/adc/mt6360-adc.c                       |  2 +-
>  drivers/iio/adc/pac1921.c                          |  8 +++---
>  drivers/iio/adc/qcom-spmi-rradc.c                  |  2 +-
>  .../iio/position/hid-sensor-custom-intel-hinge.c   |  2 +-
>  drivers/iio/resolver/ad2s1210.c                    | 30 +++++++++++-----------
>  9 files changed, 29 insertions(+), 29 deletions(-)
> ---
> base-commit: b9700f87939f0f477e5c00db817f54ab8a97702b
> change-id: 20250930-dev-sprintf-cleanup-baf2c89b3460
> --
> 
> Thanks!
> - Nuno Sá
> 
>