Re: [RFC PATCH v3 0/9] Fixes and enhancements for the bmp280 driver

[Jonathan Cameron <jic23@kernel.org>]

On Sun, 28 Sep 2025 19:26:27 +0200
Achim Gratz <Achim.Gratz@Stromeko.DE> wrote:

> Revision History:
> =================
> 
> v1:
> 	- initial proposal, incorrectly prefixed "bmp280" instead of "RFC PATCH"
> 	- patch series presented in the order it was created
> 
> v1 -> v2:
> 	- prefix as "RFC PATCH"
> 	- drop channel switching
> 	- rewrite to present patches in smaller units and in logical steps
> 
> v2 -> v3:
> 	- incorporate comments/suggestions on v2
> 	- clean up
> 
> With v6.13 a change was made to the bmp280 drivers to use MODE_FORCED
> instead of MODE_NORMAL.  This broke userspace functionality: reading
> from sysfs interfaces no longer worked and an error was thrown
> "Measurement cycle didn't complete".  This series fixes the underlying
> bugs affecting the measurement time calculation (patches 0001 through
> 005) and implements additional functionality (patches 0006 through
> 009) not available for the BMx280 devices previously to allow the use
> of the sysfs interface in MODE_NORMAL again and control the
> corresponding parameters.  The implementation follows the already
> existing facilities for the BMx[35]80 devices even though the actual
> functionality of the BMx280 hardware is slightly different.
> 
Hi Achim,
A small process related question.  Why is this an RFC?

I'd typically expect an RFC to have a cover letter with some open questions
or another statement of why the author wants comments rather than the
code to be merged.

Jonathan

> Achim Gratz (9):
>   iio: pressure: bmp280: correct meas_time_us calculation
>   iio: pressure: bmp280: implement adaptive wait for BMx280 devices
>   iio: pressure: bmp280: implement adaptive wait for BMP380 devices
>   iio: pressure: bmp280: rename wait_conv() to conv(), factor out
>     measurement time calculation
>   iio: pressure: bmp280: remove code duplication
>   iio: pressure: bmp280: enable filter settings for BMx280
>   iio: pressure: bmp280: implement sampling_frequency for BMx280
>   iio: pressure: bmp280: implement sampling_frequency calculation for
>     BMx280
>   iio: pressure: bmp280: test longer autosuspend (WIP)
> 
>  drivers/iio/pressure/bmp280-core.c | 504 +++++++++++++++++++++--------
>  drivers/iio/pressure/bmp280.h      |  26 +-
>  2 files changed, 387 insertions(+), 143 deletions(-)
>