Re: [PATCH v3 2/5] iio: accel: bma400: Use macros for generic event configuration values

[Jonathan Cameron <jic23@kernel.org>]

> > > +enum bma400_genintr_acceleval_axescomb {
> > > +     BMA400_EVAL_X_OR_Y_OR_Z,
> > > +     BMA400_EVAL_X_AND_Y_AND_Z,  
> >
> > An enum for potential field values only makes sense if you are going to
> > use it as a type somewhere.  If not it is simpler to just
> > use a define next to the mask for the field.  Also these should be named
> > with prefixes that align with that mask.
> > If you do use it as a type in future patches that's fine but the naming
> > point still remains and you should specify values = 0, = 1 etc
> > as they matter whereas implication of using an enum is that the actual
> > values assigned doesn't matter.
> >
> > Same applies to the other enums introduced in here.  
> Assigned explicit values to enums in v4 patch series.
> 
Hi Akshay,

Trivial process thing.  This email doesn't need to exist. Just
have the change called out in the change log for v4.  That way it
saves a bit of time for everyone.

Thanks,

Jonathan

> Thanks,
> Akshay.