From: Jonathan Cameron <jic23@kernel.org>
To: Akshay Jindal <akshayaj.lkd@gmail.com>
Cc: dan@dlrobertson.com, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, shuah@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/6] iio: accel: bma400: Refactor GENINTR config and register macros
Date: Sun, 12 Oct 2025 16:55:24 +0100 [thread overview]
Message-ID: <20251012165524.16a14412@jic23-huawei> (raw)
In-Reply-To: <20251007055511.108984-1-akshayaj.lkd@gmail.com>
On Tue, 7 Oct 2025 11:25:00 +0530
Akshay Jindal <akshayaj.lkd@gmail.com> wrote:
> This series refactors the BMA400 driver with a focus on generic interrupt
> configuration and related register usage. The main changes reduce
> usage of hard-coded values by introducing macros and formula-based
> register addressing, and add a centralized lookup indexed on iio event
> direction.
>
> Alongside these updates, the series also reorganizes and renames register
> and field macros for consistency with the datasheet, and extends comments
> for additional clarity.
>
> All patches are pure refactoring. No functional changes are intended.
Other than comments in patches 1 and 4 this series looks good to me.
Thanks,
Jonathan
prev parent reply other threads:[~2025-10-12 15:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 5:55 [PATCH v4 0/6] iio: accel: bma400: Refactor GENINTR config and register macros Akshay Jindal
2025-10-07 5:55 ` [PATCH v4 1/6] iio: accel: bma400: Reorganize and rename register and field macros Akshay Jindal
2025-10-12 15:52 ` Jonathan Cameron
2025-10-07 5:55 ` [PATCH v4 2/6] iio: accel: bma400: Use macros for generic event configuration values Akshay Jindal
2025-10-07 5:55 ` [PATCH v4 3/6] iio: accel: bma400: Use index-based register addressing and lookup Akshay Jindal
2025-10-07 5:55 ` [PATCH v4 4/6] iio: accel: bma400: Replace bit shifts with FIELD_PREP and FIELD_GET Akshay Jindal
2025-10-12 15:54 ` Jonathan Cameron
2025-10-07 5:55 ` [PATCH v4 5/6] iio: accel: bma400: Rename activity_event_en() to generic_event_en() Akshay Jindal
2025-10-07 5:55 ` [PATCH v4 6/6] iio: accel: bma400: Add detail to comments in GEN INTR configuration Akshay Jindal
2025-10-12 15:55 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251012165524.16a14412@jic23-huawei \
--to=jic23@kernel.org \
--cc=akshayaj.lkd@gmail.com \
--cc=andy@kernel.org \
--cc=dan@dlrobertson.com \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox