Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
Cc: lanzano.alex@gmail.com, dlechner@baylibre.com,
	nuno.sa@analog.com, andy@kernel.org, ~lkcamp/patches@lists.sr.ht,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: imu: bmi270: fix dev_err_probe error msg
Date: Sun, 12 Oct 2025 20:05:11 +0100	[thread overview]
Message-ID: <20251012200511.0a622220@jic23-huawei> (raw)
In-Reply-To: <20251010191055.28708-1-rodrigo.gobbi.7@gmail.com>

On Fri, 10 Oct 2025 16:06:46 -0300
Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com> wrote:

> The bmi270 can be connected to I2C or a SPI interface. If it is a SPI,
> during probe, if devm_regmap_init() fails, it should print the "spi"
> term rather "i2c".
> 
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
> ---
> Just fixing this little "typo", definitely it was copied from the bmi270_i2c.c [1],
> which has the same dev_err_probe logic.
> Tks and regards.
> 
> [1] https://github.com/torvalds/linux/blob/master/drivers/iio/imu/bmi270/bmi270_i2c.c#L30

Given the confusion this could cause I'm thinking this should go to stable.
It needs a fixes tag.

thanks,

Jonathan

> ---
>  drivers/iio/imu/bmi270/bmi270_spi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/imu/bmi270/bmi270_spi.c b/drivers/iio/imu/bmi270/bmi270_spi.c
> index 19dd7734f9d0..5e625586681d 100644
> --- a/drivers/iio/imu/bmi270/bmi270_spi.c
> +++ b/drivers/iio/imu/bmi270/bmi270_spi.c
> @@ -60,7 +60,7 @@ static int bmi270_spi_probe(struct spi_device *spi)
>  				  &bmi270_spi_regmap_config);
>  	if (IS_ERR(regmap))
>  		return dev_err_probe(dev, PTR_ERR(regmap),
> -				     "Failed to init i2c regmap");
> +				     "Failed to init spi regmap");
>  
>  	return bmi270_core_probe(dev, regmap, chip_info);
>  }


      parent reply	other threads:[~2025-10-12 19:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-10 19:06 [PATCH] iio: imu: bmi270: fix dev_err_probe error msg Rodrigo Gobbi
2025-10-11 14:30 ` Andy Shevchenko
2025-10-12 19:05 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251012200511.0a622220@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=lanzano.alex@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=rodrigo.gobbi.7@gmail.com \
    --cc=~lkcamp/patches@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox