* [PATCH] iio: imu: bmi270: fix dev_err_probe error msg
@ 2025-10-10 19:06 Rodrigo Gobbi
2025-10-11 14:30 ` Andy Shevchenko
2025-10-12 19:05 ` Jonathan Cameron
0 siblings, 2 replies; 3+ messages in thread
From: Rodrigo Gobbi @ 2025-10-10 19:06 UTC (permalink / raw)
To: lanzano.alex, jic23, dlechner, nuno.sa, andy
Cc: ~lkcamp/patches, linux-iio, linux-kernel
The bmi270 can be connected to I2C or a SPI interface. If it is a SPI,
during probe, if devm_regmap_init() fails, it should print the "spi"
term rather "i2c".
Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
---
Just fixing this little "typo", definitely it was copied from the bmi270_i2c.c [1],
which has the same dev_err_probe logic.
Tks and regards.
[1] https://github.com/torvalds/linux/blob/master/drivers/iio/imu/bmi270/bmi270_i2c.c#L30
---
drivers/iio/imu/bmi270/bmi270_spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/imu/bmi270/bmi270_spi.c b/drivers/iio/imu/bmi270/bmi270_spi.c
index 19dd7734f9d0..5e625586681d 100644
--- a/drivers/iio/imu/bmi270/bmi270_spi.c
+++ b/drivers/iio/imu/bmi270/bmi270_spi.c
@@ -60,7 +60,7 @@ static int bmi270_spi_probe(struct spi_device *spi)
&bmi270_spi_regmap_config);
if (IS_ERR(regmap))
return dev_err_probe(dev, PTR_ERR(regmap),
- "Failed to init i2c regmap");
+ "Failed to init spi regmap");
return bmi270_core_probe(dev, regmap, chip_info);
}
--
2.48.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: imu: bmi270: fix dev_err_probe error msg
2025-10-10 19:06 [PATCH] iio: imu: bmi270: fix dev_err_probe error msg Rodrigo Gobbi
@ 2025-10-11 14:30 ` Andy Shevchenko
2025-10-12 19:05 ` Jonathan Cameron
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2025-10-11 14:30 UTC (permalink / raw)
To: Rodrigo Gobbi
Cc: lanzano.alex, jic23, dlechner, nuno.sa, andy, ~lkcamp/patches,
linux-iio, linux-kernel
On Fri, Oct 10, 2025 at 10:11 PM Rodrigo Gobbi
<rodrigo.gobbi.7@gmail.com> wrote:
>
> The bmi270 can be connected to I2C or a SPI interface. If it is a SPI,
> during probe, if devm_regmap_init() fails, it should print the "spi"
> term rather "i2c".
rather than
...
> if (IS_ERR(regmap))
> return dev_err_probe(dev, PTR_ERR(regmap),
> - "Failed to init i2c regmap");
> + "Failed to init spi regmap");
While at it, add a trailing \n.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: imu: bmi270: fix dev_err_probe error msg
2025-10-10 19:06 [PATCH] iio: imu: bmi270: fix dev_err_probe error msg Rodrigo Gobbi
2025-10-11 14:30 ` Andy Shevchenko
@ 2025-10-12 19:05 ` Jonathan Cameron
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2025-10-12 19:05 UTC (permalink / raw)
To: Rodrigo Gobbi
Cc: lanzano.alex, dlechner, nuno.sa, andy, ~lkcamp/patches, linux-iio,
linux-kernel
On Fri, 10 Oct 2025 16:06:46 -0300
Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com> wrote:
> The bmi270 can be connected to I2C or a SPI interface. If it is a SPI,
> during probe, if devm_regmap_init() fails, it should print the "spi"
> term rather "i2c".
>
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
> ---
> Just fixing this little "typo", definitely it was copied from the bmi270_i2c.c [1],
> which has the same dev_err_probe logic.
> Tks and regards.
>
> [1] https://github.com/torvalds/linux/blob/master/drivers/iio/imu/bmi270/bmi270_i2c.c#L30
Given the confusion this could cause I'm thinking this should go to stable.
It needs a fixes tag.
thanks,
Jonathan
> ---
> drivers/iio/imu/bmi270/bmi270_spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/imu/bmi270/bmi270_spi.c b/drivers/iio/imu/bmi270/bmi270_spi.c
> index 19dd7734f9d0..5e625586681d 100644
> --- a/drivers/iio/imu/bmi270/bmi270_spi.c
> +++ b/drivers/iio/imu/bmi270/bmi270_spi.c
> @@ -60,7 +60,7 @@ static int bmi270_spi_probe(struct spi_device *spi)
> &bmi270_spi_regmap_config);
> if (IS_ERR(regmap))
> return dev_err_probe(dev, PTR_ERR(regmap),
> - "Failed to init i2c regmap");
> + "Failed to init spi regmap");
>
> return bmi270_core_probe(dev, regmap, chip_info);
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-12 19:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-10 19:06 [PATCH] iio: imu: bmi270: fix dev_err_probe error msg Rodrigo Gobbi
2025-10-11 14:30 ` Andy Shevchenko
2025-10-12 19:05 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).