Re: [PATCH] iio: dac: ad5446: Add AD5542 to the spi id table

[Jonathan Cameron <jic23@kernel.org>]

On Wed, 15 Oct 2025 09:08:36 +0100
Nuno Sá <noname.nuno@gmail.com> wrote:

> On Tue, 2025-10-14 at 12:15 -0500, David Lechner wrote:
> > On 10/14/25 11:11 AM, Nuno Sá via B4 Relay wrote:  
> > > From: Michael Hennerich <michael.hennerich@analog.com>
> > > 
> > > This adds support for the AD5542 single channel Current Source and
> > > Voltage Output DACs.
> > > 
> > > It is similar to the AD5542A model so just use the same id.
> > > 
> > > Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> > > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > > ---
> > >  drivers/iio/dac/ad5446.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c
> > > index ad304b0fec08..6e4103f4afcb 100644
> > > --- a/drivers/iio/dac/ad5446.c
> > > +++ b/drivers/iio/dac/ad5446.c
> > > @@ -422,6 +422,7 @@ static const struct spi_device_id ad5446_spi_ids[] = {
> > >  	{"ad5512a", ID_AD5512A},
> > >  	{"ad5541a", ID_AD5541A},
> > >  	{"ad5542a", ID_AD5541A}, /* ad5541a and ad5542a are compatible */
> > > +	{"ad5542", ID_AD5541A}, /* ad5541a and ad5542a are compatible */  
> > 
> > Should the comment say ad5542 instead of ad5542a?  
> 
> Yes.
> 
> >   
> > >  	{"ad5543", ID_AD5541A}, /* ad5541a and ad5543 are compatible */
> > >  	{"ad5553", ID_AD5553},
> > >  	{"ad5600", ID_AD5600},
> > > 
> > > ---
> > > base-commit: 4b17a60d1e1c2d9d2ccbd58642f6f4ac2fa364ba
> > > change-id: 20251014-dev-add-ad5542-8c8934de80ee
> > > --
> > > 
> > > Thanks!
> > > - Nuno Sá
> > > 
> > >   
> > 
> > Interesting... no devicetree bindings for these chips?  
> 
> This driver is old enough where things were less strict (I guess) and it seems
> no one added bindings for this.
Dates back to board file days I think. Relying on the stuff that was added
to bridge that gap by matching stripped part number from compatible against the
i2c_device_id.

If you fancy tidying that up and adding both of_device_id table and a binding
doc that would be great.

Thanks,

J
> 
> - Nuno Sá