From: Jonathan Cameron <jic23@kernel.org>
To: Petre Rodan <petre.rodan@subdimension.ro>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] iio: accel: bma220: add low-g event detection
Date: Sat, 18 Oct 2025 18:22:26 +0100 [thread overview]
Message-ID: <20251018182226.28335afb@jic23-huawei> (raw)
In-Reply-To: <20251014-bma220_events-v1-4-153424d7ea08@subdimension.ro>
> @@ -790,6 +884,13 @@ static irqreturn_t bma220_irq_handler(int irq, void *private)
> return IRQ_HANDLED;
> }
>
> + if (FIELD_GET(BMA220_IF_LOW, bma220_reg_if1))
> + iio_push_event(indio_dev,
> + IIO_MOD_EVENT_CODE(IIO_ACCEL, 0,
> + IIO_MOD_X_OR_Y_OR_Z,
I only noticed this when looking at next patch.
Would be unusual to have reporting on 'any' acceleration dropping below
a threshold. Tends to be all drop (which is free fall detection).
I checked the datasheet quickly and looks like this should be
IIO_MOD_X_AND_Y_AND_Z which is what we normally see for an inactivity / freefall
threshold detector.
> + IIO_EV_TYPE_THRESH,
> + IIO_EV_DIR_FALLING),
> + timestamp);
> if (FIELD_GET(BMA220_IF_TT, bma220_reg_if1)) {
>
> if (data->tap_type == BMA220_TAP_TYPE_SINGLE)
>
next prev parent reply other threads:[~2025-10-18 17:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 16:42 [PATCH 0/6] iio: accel: bma220: add events Petre Rodan
2025-10-14 16:42 ` [PATCH 1/6] iio: accel: bma220: white space cleanup Petre Rodan
2025-10-18 16:55 ` Jonathan Cameron
2025-10-14 16:42 ` [PATCH 2/6] iio: accel: bma220: remove useless include Petre Rodan
2025-10-18 16:55 ` Jonathan Cameron
2025-10-14 16:42 ` [PATCH 3/6] iio: accel: bma220: add tap detection Petre Rodan
2025-10-18 17:16 ` Jonathan Cameron
2025-11-01 7:56 ` Petre Rodan
2025-11-02 12:20 ` Jonathan Cameron
2025-11-07 0:30 ` Petre Rodan
2025-11-09 12:41 ` Jonathan Cameron
2025-10-14 16:43 ` [PATCH 4/6] iio: accel: bma220: add low-g event detection Petre Rodan
2025-10-18 17:20 ` Jonathan Cameron
2025-10-18 17:22 ` Jonathan Cameron [this message]
2025-10-14 16:43 ` [PATCH 5/6] iio: accel: bma220: add high-g " Petre Rodan
2025-10-14 16:43 ` [PATCH 6/6] iio: accel: bma220: add any-motion detection Petre Rodan
2025-10-18 17:32 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251018182226.28335afb@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=petre.rodan@subdimension.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox