From: Jonathan Cameron <jic23@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: adc: qcom-vadc-common: fix vadc_scale_fn_type kernel-doc
Date: Sun, 19 Oct 2025 09:44:58 +0100 [thread overview]
Message-ID: <20251019094458.141971a7@jic23-huawei> (raw)
In-Reply-To: <20251017070728.1637804-1-rdunlap@infradead.org>
On Fri, 17 Oct 2025 00:07:27 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:
> Fix multiple warnings in enum vadc_scale_fn_type by adding a leading
> '@' to the kernel-doc descriptions.
>
> Fixed 14 warnings in this one enum, such as:
> Warning: include/linux/iio/adc/qcom-vadc-common.h:123 Enum value
> 'SCALE_DEFAULT' not described in enum 'vadc_scale_fn_type'
> Warning: ../include/linux/iio/adc/qcom-vadc-common.h:123 Enum value
> 'SCALE_THERM_100K_PULLUP' not described in enum 'vadc_scale_fn_type'
> Warning: ../include/linux/iio/adc/qcom-vadc-common.h:123 Enum value
> 'SCALE_PMIC_THERM' not described in enum 'vadc_scale_fn_type'
>
> Also prevent the warning on SCALE_HW_CALIB_INVALID by marking it
> "private:" so that kernel-doc notation is not needed for it.
>
> This leaves only one warning here, which I don't know the
> appropriate description of:
> qcom-vadc-common.h:125: warning: Enum value
> 'SCALE_HW_CALIB_PMIC_THERM_PM7' not described in enum 'vadc_scale_fn_type'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Thanks for cleaning this up. Hopefully someone else will follow up
with the description for the missing one.
Applied,
Jonathan
>
prev parent reply other threads:[~2025-10-19 8:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 7:07 [PATCH] iio: adc: qcom-vadc-common: fix vadc_scale_fn_type kernel-doc Randy Dunlap
2025-10-19 8:44 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251019094458.141971a7@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=dlechner@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox