From: Jonathan Cameron <jic23@kernel.org>
To: Dimitri Fedrau via B4 Relay
<devnull+dimitri.fedrau.liebherr.com@kernel.org>
Cc: dimitri.fedrau@liebherr.com,
"Javier Carrasco" <javier.carrasco.cruz@gmail.com>,
"Li peiyu" <579lpy@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Dimitri Fedrau" <dima.fedrau@gmail.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Chris Lesiak" <chris.lesiak@licorbio.com>
Subject: Re: [PATCH v4 0/2] iio: humditiy: hdc3020: fix units
Date: Sun, 19 Oct 2025 09:48:49 +0100 [thread overview]
Message-ID: <20251019094849.0b904e2c@jic23-huawei> (raw)
In-Reply-To: <20251016-hdc3020-units-fix-v4-0-2d9e9f33c7b1@liebherr.com>
On Thu, 16 Oct 2025 07:20:37 +0200
Dimitri Fedrau via B4 Relay <devnull+dimitri.fedrau.liebherr.com@kernel.org> wrote:
> Fix units to milli degree celsius and milli percent for temperature
> respectively relative humidity measurements and thresholds.
>
> Signed-off-by: Dimitri Fedrau <dimitri.fedrau@liebherr.com>
Hi Dimitri,
I think this covers the last bits of feedback so I'll queue it up in the
fixes-togreg branch of iio.git. I'll probably not send a pull request
for that for a few more days though so there is still time for additional
feedback.
Also marked for stable.
Thanks
Jonathan
> ---
> Changes in v4:
> - Add explicit formula into comments of hdc3020_thresh_get_temp and
> hdc3020_thresh_get_hum
> - Add explicit division by 5 into calculations in hdc3020_thresh_get_temp
> and hdc3020_thresh_get_hum
> - Link to v3: https://lore.kernel.org/r/20251013-hdc3020-units-fix-v3-0-b21fab32b882@liebherr.com
>
> Changes in v3:
> - Fix verbose comment for define HDC3020_THRESH_FRACTION (Javier)
> - Embed prescale into define HDC3020_THRESH_FRACTION to make the division
> by 5 calculation in threshold calculations explicit. (Andy)
> - Add resulting units into comments again in hdc3020_thresh_get_temp and
> hdc3020_thresh_get_hum (Andy)
> - Link to v2: https://lore.kernel.org/r/20250901-hdc3020-units-fix-v2-0-082038a15917@liebherr.com
>
> Changes in v2:
> - Added explanation what is wrong at the moment into commit msg
> - Added define HDC3020_THRESH_FRACTION and comment at the beginning of the
> code.
> - Use MILLI for instead of hardcoded 1000.
> - Link to v1: https://lore.kernel.org/r/20250821-hdc3020-units-fix-v1-0-6ab0bc353c5e@liebherr.com
>
> ---
> Dimitri Fedrau (2):
> iio: humditiy: hdc3020: fix units for temperature and humidity measurement
> iio: humditiy: hdc3020: fix units for thresholds and hysteresis
>
> drivers/iio/humidity/hdc3020.c | 73 +++++++++++++++++++++++++-----------------
> 1 file changed, 43 insertions(+), 30 deletions(-)
> ---
> base-commit: 875e7d357a7f2e77a7f3fc4759d0aa0872c33027
> change-id: 20250820-hdc3020-units-fix-91edbb8ccd07
>
> Best regards,
prev parent reply other threads:[~2025-10-19 8:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 5:20 [PATCH v4 0/2] iio: humditiy: hdc3020: fix units Dimitri Fedrau via B4 Relay
2025-10-16 5:20 ` [PATCH v4 1/2] iio: humditiy: hdc3020: fix units for temperature and humidity measurement Dimitri Fedrau via B4 Relay
2025-10-16 5:20 ` [PATCH v4 2/2] iio: humditiy: hdc3020: fix units for thresholds and hysteresis Dimitri Fedrau via B4 Relay
2025-10-19 8:48 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251019094849.0b904e2c@jic23-huawei \
--to=jic23@kernel.org \
--cc=579lpy@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy@kernel.org \
--cc=chris.lesiak@licorbio.com \
--cc=devnull+dimitri.fedrau.liebherr.com@kernel.org \
--cc=dima.fedrau@gmail.com \
--cc=dimitri.fedrau@liebherr.com \
--cc=dlechner@baylibre.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox