From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-iio@vger.kernel.org, chrome-platform@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Benson Leung" <bleung@chromium.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
Subject: [PATCH v1 1/6] media: vidtv: Rename PI definition to PI_SAMPLES
Date: Mon, 27 Oct 2025 15:34:50 +0100 [thread overview]
Message-ID: <20251027143850.2070427-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20251027143850.2070427-1-andriy.shevchenko@linux.intel.com>
The definition of PI in the driver is not the actual value in radians,
but rather degrees. Since we are going to have a value in radians
defined in a global header, rename this definition to avoid potential
collisions. No functional changes.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/media/test-drivers/vidtv/vidtv_s302m.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/test-drivers/vidtv/vidtv_s302m.c b/drivers/media/test-drivers/vidtv/vidtv_s302m.c
index 9da18eac04b5..b3217d643b1e 100644
--- a/drivers/media/test-drivers/vidtv/vidtv_s302m.c
+++ b/drivers/media/test-drivers/vidtv/vidtv_s302m.c
@@ -45,7 +45,7 @@
#define FF_S302M_DEFAULT_PTS_OFFSET 100000
/* Used by the tone generator: number of samples for PI */
-#define PI 180
+#define PI_SAMPLES 180
static const u8 reverse[256] = {
/* from ffmpeg */
@@ -259,10 +259,10 @@ static u16 vidtv_s302m_get_sample(struct vidtv_encoder *e)
if (!ctx->last_tone)
return 0x8000;
- pos = (2 * PI * ctx->note_offset * ctx->last_tone) / S302M_SAMPLING_RATE_HZ;
+ pos = (2 * PI_SAMPLES * ctx->note_offset * ctx->last_tone) / S302M_SAMPLING_RATE_HZ;
ctx->note_offset++;
- return (fixp_sin32(pos % (2 * PI)) >> 16) + 0x8000;
+ return (fixp_sin32(pos % (2 * PI_SAMPLES)) >> 16) + 0x8000;
}
/* bug somewhere */
--
2.50.1
next prev parent reply other threads:[~2025-10-27 14:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 14:34 [PATCH v1 0/6] iio: Introduce and use value of π Andy Shevchenko
2025-10-27 14:34 ` Andy Shevchenko [this message]
2025-10-30 7:24 ` [PATCH v1 1/6] media: vidtv: Rename PI definition to PI_SAMPLES Hans Verkuil
2025-10-27 14:34 ` [PATCH v1 2/6] units: Add value of π * 10⁹ Andy Shevchenko
2025-10-27 14:52 ` Jonathan Cameron
2025-10-27 14:59 ` David Lechner
2025-10-28 8:09 ` Andy Shevchenko
2025-10-27 19:30 ` David Laight
2025-10-28 8:08 ` Andy Shevchenko
2025-10-28 9:27 ` David Laight
2025-10-27 14:34 ` [PATCH v1 3/6] media: dvb-frontends: atbm8830: Convert to use PI definition Andy Shevchenko
2025-10-30 7:26 ` Hans Verkuil
2025-10-27 14:34 ` [PATCH v1 4/6] iio: cros_ec_sensors: " Andy Shevchenko
2025-10-27 14:34 ` [PATCH v1 5/6] iio: frequency: ad9523: " Andy Shevchenko
2025-10-27 14:34 ` [PATCH v1 6/6] iio: position: iqs624-pos: " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251027143850.2070427-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dlechner@baylibre.com \
--cc=dwlsalmeida@gmail.com \
--cc=groeck@chromium.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).