From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F37A218AD1; Mon, 27 Oct 2025 14:38:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761575940; cv=none; b=psYbMLfPPSlqKMVAo2ebJQv7vWaR9Y1KGPWKVBZ2aWDOSdWx15YJwFsCTSSkLVRr8/1Zb0v7Aq7xLGwfotvhh+TG4TrLrzhMYbaf3XFtAwnIv5ps+ih9QMu+gkLj+T80vXaoLGx2kSteJrMVr5a2Q0VUkIGeMFRVSjF31DzzxOA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761575940; c=relaxed/simple; bh=kgLsFhWseh0ujDYIDdowa7yD3Ra0B33OBKNPNc/z5WY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eubeDD+qu5QrgyiEeu38/M1AMSR9rFS74t159Yhf7lxlHj8FNBybplHmLr1V/FMMJNk3m8BsTMTKrwfRdu3pRJASykdNMt8sowlsC1jjUQ95YxAgR9N+j8Wo32yLB0L2fQA2lHuPZALD2uptEnkJtT0N3zRONaMzDzauhycm9MU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Laimmuns; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Laimmuns" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1761575938; x=1793111938; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kgLsFhWseh0ujDYIDdowa7yD3Ra0B33OBKNPNc/z5WY=; b=Laimmunsicr9TMjGLj6B/uiiAqNDDwQp14Z4W3ed2035PbtptFeGYT1m linHqC5uTUYQXy8xmayTqtg9j5xIbqoa9Fx79gcDjMZK08rdXYDc2X3i8 lHgN0Qfi2he+6cdUpYlybumok5nYFmdgcK1PpUoyD2yhR2sOFoJG8fjed 3zi01rQnFr1lZ201RxkxyxCA5TelLhlUQKGSLpa/PCJQYucPoSuXRgfaz jXC/RZaK/OOEZJqD8ZQ0/1EhjrA5w/inH6y1xhRX6fhdI6yZGMp63Ge73 OAPFcgfcEMNNyb85cAt9FYXO4wh3bYxL0S+9vtphh7o4rbuUG1RPaq/pD A==; X-CSE-ConnectionGUID: cc4p9ZHvQli9bBBwkKZVzA== X-CSE-MsgGUID: nWUxzgujTFuOL7aHlY2nJg== X-IronPort-AV: E=McAfee;i="6800,10657,11586"; a="67299498" X-IronPort-AV: E=Sophos;i="6.19,259,1754982000"; d="scan'208";a="67299498" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2025 07:38:57 -0700 X-CSE-ConnectionGUID: tvtm8zCpQXWL1kiPvyOWLA== X-CSE-MsgGUID: frXLvfIjQb2EQex6nulUCg== X-ExtLoop1: 1 Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa003.fm.intel.com with ESMTP; 27 Oct 2025 07:38:54 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 4CE0696; Mon, 27 Oct 2025 15:38:53 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , linux-iio@vger.kernel.org, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Cc: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Benson Leung , Guenter Roeck , Lars-Peter Clausen , Michael Hennerich , Mauro Carvalho Chehab , "Daniel W. S. Almeida" Subject: [PATCH v1 1/6] media: vidtv: Rename PI definition to PI_SAMPLES Date: Mon, 27 Oct 2025 15:34:50 +0100 Message-ID: <20251027143850.2070427-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251027143850.2070427-1-andriy.shevchenko@linux.intel.com> References: <20251027143850.2070427-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The definition of PI in the driver is not the actual value in radians, but rather degrees. Since we are going to have a value in radians defined in a global header, rename this definition to avoid potential collisions. No functional changes. Signed-off-by: Andy Shevchenko --- drivers/media/test-drivers/vidtv/vidtv_s302m.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/test-drivers/vidtv/vidtv_s302m.c b/drivers/media/test-drivers/vidtv/vidtv_s302m.c index 9da18eac04b5..b3217d643b1e 100644 --- a/drivers/media/test-drivers/vidtv/vidtv_s302m.c +++ b/drivers/media/test-drivers/vidtv/vidtv_s302m.c @@ -45,7 +45,7 @@ #define FF_S302M_DEFAULT_PTS_OFFSET 100000 /* Used by the tone generator: number of samples for PI */ -#define PI 180 +#define PI_SAMPLES 180 static const u8 reverse[256] = { /* from ffmpeg */ @@ -259,10 +259,10 @@ static u16 vidtv_s302m_get_sample(struct vidtv_encoder *e) if (!ctx->last_tone) return 0x8000; - pos = (2 * PI * ctx->note_offset * ctx->last_tone) / S302M_SAMPLING_RATE_HZ; + pos = (2 * PI_SAMPLES * ctx->note_offset * ctx->last_tone) / S302M_SAMPLING_RATE_HZ; ctx->note_offset++; - return (fixp_sin32(pos % (2 * PI)) >> 16) + 0x8000; + return (fixp_sin32(pos % (2 * PI_SAMPLES)) >> 16) + 0x8000; } /* bug somewhere */ -- 2.50.1