Re: [PATCH v3 09/10] iio: dac: ad5446: Fix coding style issues

[Jonathan Cameron <jic23@kernel.org>]

On Fri, 31 Oct 2025 12:31:30 +0000
Nuno Sá via B4 Relay <devnull+nuno.sa.analog.com@kernel.org> wrote:

> From: Nuno Sá <nuno.sa@analog.com>
> 
> Fix style issues as reported by checkpatch. Additionally, make sure
> include files are given in alphabetical order and that we include the
> ones that were missing and remove the one we don't really use.
If it's only 1 say what it is.  I see quite a few so guessing that
was meant to be plural?

Headers and white space are different things so really should be
2 patches.

Actual changes all look good

Jonathan

> 
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> ---
>  drivers/iio/dac/ad5446.c | 41 ++++++++++++++++++-----------------------
>  1 file changed, 18 insertions(+), 23 deletions(-)
> 
> diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c
> index d288fb56e324..bf9f7edb1a81 100644
> --- a/drivers/iio/dac/ad5446.c
> +++ b/drivers/iio/dac/ad5446.c
> @@ -5,21 +5,17 @@
>   * Copyright 2010 Analog Devices Inc.
>   */
>  
> +#include <linux/array_size.h>
>  #include <linux/cleanup.h>
> -#include <linux/export.h>
> -#include <linux/interrupt.h>
> -#include <linux/workqueue.h>
>  #include <linux/device.h>
> -#include <linux/kernel.h>
> -#include <linux/slab.h>
> -#include <linux/sysfs.h>
> -#include <linux/list.h>
> -#include <linux/regulator/consumer.h>
>  #include <linux/err.h>
> -#include <linux/module.h>
> -
> +#include <linux/export.h>
>  #include <linux/iio/iio.h>
> -#include <linux/iio/sysfs.h>
> +#include <linux/kstrtox.h>
> +#include <linux/module.h>
> +#include <linux/mutex.h>
> +#include <linux/regulator/consumer.h>
> +#include <linux/sysfs.h>
>  
>  #include "ad5446.h"