From: Jonathan Cameron <jic23@kernel.org>
To: "Nuno Sá" <noname.nuno@gmail.com>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>
Subject: Re: [PATCH v1 0/3] iio: core: fix error path in iio_device_alloc()
Date: Sat, 15 Nov 2025 17:29:30 +0000 [thread overview]
Message-ID: <20251115172930.3b06d771@jic23-huawei> (raw)
In-Reply-To: <0ec0086b91528e67c9a5c1fe4c27b65a3cc9f8aa.camel@gmail.com>
On Wed, 12 Nov 2025 18:00:42 +0000
Nuno Sá <noname.nuno@gmail.com> wrote:
> On Wed, 2025-11-12 at 15:55 +0100, Andy Shevchenko wrote:
> > The series is induced by the similar fixes in viio_trigger_alloc().
> > Basically two things happen here: 1) add missed mutex_destroy()
> > calls, and 2) refactor to make sure we clean resources with put_device()
> > when appropriate.
> >
> > Andy Shevchenko (3):
> > iio: core: add missing mutex_destroy in iio_dev_release()
> > iio: core: Clean up device correctly on iio_device_alloc() failure
> > iio: core: Replace lockdep_set_class() + mutex_init() by combined call
> >
> > drivers/iio/industrialio-core.c | 18 +++++++++++-------
> > 1 file changed, 11 insertions(+), 7 deletions(-)
>
> LGTM,
>
> Reviewed-by: Nuno Sá <nuno.sa@analog.com>
>
I'm not going to rush these in given where we are in the cycle
and the fact only some are fixes (and really no one cares that
much about mutex_destroy() as it only does anything at all in
a particular debug setup.)
So applied to the togreg branch of iio.git and pushed out as testing
for now.
Thanks,
Jonathan
prev parent reply other threads:[~2025-11-15 17:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 14:55 [PATCH v1 0/3] iio: core: fix error path in iio_device_alloc() Andy Shevchenko
2025-11-12 14:55 ` [PATCH v1 1/3] iio: core: add missing mutex_destroy in iio_dev_release() Andy Shevchenko
2025-11-12 14:55 ` [PATCH v1 2/3] iio: core: Clean up device correctly on iio_device_alloc() failure Andy Shevchenko
2025-11-12 14:55 ` [PATCH v1 3/3] iio: core: Replace lockdep_set_class() + mutex_init() by combined call Andy Shevchenko
2025-11-12 18:00 ` [PATCH v1 0/3] iio: core: fix error path in iio_device_alloc() Nuno Sá
2025-11-15 17:29 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251115172930.3b06d771@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noname.nuno@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox