From: Jonathan Cameron <jic23@kernel.org>
To: Ajith Anandhan <ajithanandhan0406@gmail.com>
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: adc: Add TI ADS1120 binding
Date: Sat, 15 Nov 2025 18:31:44 +0000 [thread overview]
Message-ID: <20251115183144.15b3e236@jic23-huawei> (raw)
In-Reply-To: <20251109141119.561756-2-ajithanandhan0406@gmail.com>
On Sun, 9 Nov 2025 19:41:18 +0530
Ajith Anandhan <ajithanandhan0406@gmail.com> wrote:
> Add device tree binding documentation for the Texas Instruments
> ADS1120.
>
> The binding defines required properties like compatible, reg, and
> SPI configuration parameters.
>
> Signed-off-by: Ajith Anandhan <ajithanandhan0406@gmail.com>
> ---
> .../bindings/iio/adc/ti,ads1120.yaml | 109 ++++++++++++++++++
> 1 file changed, 109 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads1120.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1120.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1120.yaml
> new file mode 100644
> index 000000000..2449094af
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1120.yaml
>
> +
> + vref-supply:
> + description: |
> + Optional external voltage reference. Can be connected to either
> + REFP0/REFN0 or REFP1/REFN1 pins. If not supplied, the internal
> + 2.048V reference is used.
How do you know which set of inputs is used? Looks like a register
needs to be programmed to pick between them.
> +
> + ti,avdd-is-ref:
> + type: boolean
> + description: |
> + If present, indicates that the AVDD supply voltage is of sufficient
> + quality and stability to be used as the voltage reference instead of
> + the internal reference. This allows the driver to select AVDD as the
> + reference source for potentially better performance.
This one is interesting as I don't recall anyone arguing this made
sense before. In what way better performance? Are their boards out
there where this definitely makes sense to do?
next prev parent reply other threads:[~2025-11-15 18:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-09 14:11 [PATCH v2 0/2] iio: adc: ti-ads1120: Add driver and dt-binding Ajith Anandhan
2025-11-09 14:11 ` [PATCH v2 1/2] dt-bindings: iio: adc: Add TI ADS1120 binding Ajith Anandhan
2025-11-10 7:59 ` Krzysztof Kozlowski
2025-11-15 18:31 ` Jonathan Cameron [this message]
2025-11-18 0:19 ` David Lechner
2025-12-15 14:49 ` Ajith Anandhan
2025-12-15 15:58 ` David Lechner
2025-11-09 14:11 ` [PATCH v2 2/2] iio: adc: Add support for TI ADS1120 Ajith Anandhan
2025-11-09 17:03 ` Andy Shevchenko
2025-11-09 17:05 ` Andy Shevchenko
2025-11-10 10:17 ` kernel test robot
2025-11-15 18:45 ` Jonathan Cameron
2025-11-18 14:04 ` David Lechner
2025-12-15 16:13 ` Ajith Anandhan
2025-12-15 16:36 ` David Lechner
2025-12-15 16:49 ` Ajith Anandhan
2025-12-15 17:00 ` Andy Shevchenko
2025-12-15 17:38 ` Ajith Anandhan
2025-12-15 17:42 ` David Lechner
2025-12-15 17:50 ` Ajith Anandhan
2025-12-21 18:57 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251115183144.15b3e236@jic23-huawei \
--to=jic23@kernel.org \
--cc=ajithanandhan0406@gmail.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox