Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Shi Hao <i.shihao.999@gmail.com>,
	Michael.Hennerich@analog.com, lars@metafoo.de,
	dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
	gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: adt7316: replace sprintf() with sysfs_emit()
Date: Sun, 16 Nov 2025 15:28:00 +0000	[thread overview]
Message-ID: <20251116152800.4c1849cc@jic23-huawei> (raw)
In-Reply-To: <CAHp75VdY7W8EgOfKuxtTALj777aVatxV5dqsxm688JTy=iVW2Q@mail.gmail.com>

On Sun, 16 Nov 2025 13:08:07 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Sun, Nov 16, 2025 at 12:16 PM Shi Hao <i.shihao.999@gmail.com> wrote:
> >
> > Convert several sprintf() calls to sysfs_emit() in the
> > sysfs show functions, as it is the preferred helper and
> > prevents potential buffer overruns.
> >
> > No functional changes intended.  
> 
> I briefly looked at it and see no issues,
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
> 

Applied, but I will note that this driver is a long way from suitable
for moving out of staging and I would be surprised if more than
one or two of the lines changed in this patch make it through the
necessary refactors (should anyone actually have another go at
doing them).  Anyhow, I still think this is worth taking just to
reduce the noise of remaining instances of this.

I'd have deleted this long ago except I actually have one somewhere
and it one of the supported parts was still listed as suitable for
new designs when I checked not long ago.

ADI folk, I would like to hear if we should just delete this one.

Thanks,

Jonathan

  reply	other threads:[~2025-11-16 15:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-16 10:16 [PATCH] staging: iio: adt7316: replace sprintf() with sysfs_emit() Shi Hao
2025-11-16 11:08 ` Andy Shevchenko
2025-11-16 15:28   ` Jonathan Cameron [this message]
2025-11-18  8:18     ` Nuno Sá
2025-11-18 12:10       ` Andy Shevchenko
2025-11-19 14:57         ` Jonathan Cameron
2025-12-01 16:51           ` Marcelo Schmitt
2025-12-02 13:55           ` Nuno Sá

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251116152800.4c1849cc@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=i.shihao.999@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox