Re: [PATCH v3 2/3] iio: amplifiers: adl8113: add driver support

[Jonathan Cameron <jic23@kernel.org>]

On Fri, 14 Nov 2025 11:57:24 +0000
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:

> Add support for adl8113 10MHz to 12GHz Low Noise Amplifier with
> 10MHz to 14GHz bypass switches.
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
Hi Antoniu

A few really minor things inline that are in the category of
things I'd just tidy up whilst applying.

However, I want to know more about real usecases.  Probably best
place to discuss those is wrt to patch 3 so I'll reply to that.


> diff --git a/drivers/iio/amplifiers/adl8113.c b/drivers/iio/amplifiers/adl8113.c
> new file mode 100644
> index 000000000000..155291f4ec89
> --- /dev/null
> +++ b/drivers/iio/amplifiers/adl8113.c
> @@ -0,0 +1,252 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * ADL8113 Low Noise Amplifier with integrated bypass switches
> + *
> + * Copyright 2025 Analog Devices Inc.
> + */
> +
> +#include <linux/array_size.h>
> +#include <linux/device.h>
> +#include <linux/err.h>
> +#include <linux/gpio/consumer.h>
> +#include <linux/iio/iio.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/module.h>
> +#include <linux/platform_device.h>
> +#include <linux/property.h>
> +#include <linux/regulator/consumer.h>
> +#include <linux/slab.h>
> +#include <linux/sysfs.h>

Is this used?

> +static const char * const adl8113_supply_names[] = {
> +	"vdd1",
> +	"vdd2",
> +	"vss2"

This one should have a trailing comma because maybe we'll have
another supply at some future point.  At very least it's not obvious
from code alone that we never will so convention is to have that comma.

> +};

> +
> +static const struct iio_chan_spec_ext_info adl8113_ext_info[] = {
> +	IIO_ENUM("signal_path", IIO_SHARED_BY_ALL, &adl8113_signal_path_enum),
> +	IIO_ENUM_AVAILABLE("signal_path", IIO_SHARED_BY_ALL,
> +			   &adl8113_signal_path_enum),
> +	{ },

Trivial but no trailing comma given nothing can come after this.

> +};