Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Fiona Klute" <fiona.klute@gmx.de>,
	"Roan van Dijk" <roan@protonic.nl>,
	linux-iio@vger.kernel.org, "Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: chemical: scd4x: fix reported channel endianness
Date: Sat, 27 Dec 2025 16:42:19 +0000	[thread overview]
Message-ID: <20251227164219.5ffa1b60@jic23-huawei> (raw)
In-Reply-To: <64181fc9-4795-4c5b-97de-a9482eea4bf4@baylibre.com>

On Mon, 15 Dec 2025 10:41:04 -0600
David Lechner <dlechner@baylibre.com> wrote:

> On 12/13/25 10:32 AM, Fiona Klute wrote:
> > The driver converts values read from the sensor from BE to CPU
> > endianness in scd4x_read_meas(). The result is then pushed into the
> > buffer in scd4x_trigger_handler(), so on LE architectures parsing the
> > buffer using the reported BE type gave wrong results.
> > 
> > scd4x_read_raw() which provides sysfs *_raw values is not affected, it
> > used the values returned by scd4x_read_meas() without further
> > conversion.
> > 
> > Fixes: 49d22b695cbb6 ("drivers: iio: chemical: Add support for Sensirion SCD4x CO2 sensor")
> > Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
> > ---  
> Reviewed-by: David Lechner <dlechner@baylibre.com>
> 
> 

Oops. Seems I queued this up but never replied to say I had done so
(or updated patchwork). This is on the fixes-togreg branch of iio.git.

Thanks,

Jonathan

      reply	other threads:[~2025-12-27 16:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-13 16:32 [PATCH] iio: chemical: scd4x: fix reported channel endianness Fiona Klute
2025-12-15 16:41 ` David Lechner
2025-12-27 16:42   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251227164219.5ffa1b60@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=fiona.klute@gmx.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=roan@protonic.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox