public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Chen Ni <nichen@iscas.ac.cn>,
	lars@metafoo.de, Michael.Hennerich@analog.com,
	dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad7476: Remove duplicate include
Date: Sun, 11 Jan 2026 13:16:58 +0000	[thread overview]
Message-ID: <20260111131658.005da0a6@jic23-huawei> (raw)
In-Reply-To: <fd506e0f-9e52-498d-8e35-077ab52efbd7@gmail.com>

On Thu, 8 Jan 2026 08:06:13 +0200
Matti Vaittinen <mazziesaccount@gmail.com> wrote:

> On 07/01/2026 10:29, Chen Ni wrote:
> > Remove duplicate inclusion of linux/bitops.h.
> > 
> > Signed-off-by: Chen Ni <nichen@iscas.ac.cn>  
> 
> I would also appreciate having the includes alphabetically ordered as 
> Andy suggested. This, however, is a fine fix as it is so:
> 
> Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
Applied this one.  As Andy observes in v2 review the first patch
should be this anyway!

Thanks,

Jonathan

> 
> > ---
> >   drivers/iio/adc/ad7476.c | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/iio/adc/ad7476.c b/drivers/iio/adc/ad7476.c
> > index 1bec6657394c..21d3f6aae972 100644
> > --- a/drivers/iio/adc/ad7476.c
> > +++ b/drivers/iio/adc/ad7476.c
> > @@ -16,7 +16,6 @@
> >   #include <linux/gpio/consumer.h>
> >   #include <linux/err.h>
> >   #include <linux/module.h>
> > -#include <linux/bitops.h>
> >   #include <linux/delay.h>
> >   
> >   #include <linux/iio/iio.h>  
> 
> 


      reply	other threads:[~2026-01-11 13:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07  8:29 [PATCH] iio: adc: ad7476: Remove duplicate include Chen Ni
2026-01-07 15:29 ` Andy Shevchenko
2026-01-08  6:06 ` Matti Vaittinen
2026-01-11 13:16   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260111131658.005da0a6@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    --cc=nichen@iscas.ac.cn \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox