From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev,
"Francesco Lavra" <flavra@baylibre.com>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH v3 3/3] iio: imu: st_lsm6dsx: add support for rotation sensor
Date: Tue, 20 Jan 2026 09:46:09 +0300 [thread overview]
Message-ID: <202601200451.4BeA8JAe-lkp@intel.com> (raw)
In-Reply-To: <20260119100449.1559624-4-flavra@baylibre.com>
Hi Francesco,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Francesco-Lavra/iio-imu-st_lsm6dsx-set-FIFO-ODR-for-accelerometer-and-gyroscope-only/20260119-181615
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link: https://lore.kernel.org/r/20260119100449.1559624-4-flavra%40baylibre.com
patch subject: [PATCH v3 3/3] iio: imu: st_lsm6dsx: add support for rotation sensor
config: sparc-randconfig-r071-20260119 (https://download.01.org/0day-ci/archive/20260120/202601200451.4BeA8JAe-lkp@intel.com/config)
compiler: sparc-linux-gcc (GCC) 15.2.0
smatch version: v0.5.0-8985-g2614ff1a
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202601200451.4BeA8JAe-lkp@intel.com/
smatch warnings:
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_fusion.c:90 st_lsm6dsx_sf_set_odr() error: uninitialized symbol 'odr_val'.
vim +/odr_val +90 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_fusion.c
aa03865dcb5ed7 Francesco Lavra 2026-01-19 70 int st_lsm6dsx_sf_set_odr(struct st_lsm6dsx_sensor *sensor, bool enable)
aa03865dcb5ed7 Francesco Lavra 2026-01-19 71 {
aa03865dcb5ed7 Francesco Lavra 2026-01-19 72 struct st_lsm6dsx_hw *hw = sensor->hw;
aa03865dcb5ed7 Francesco Lavra 2026-01-19 73 const struct st_lsm6dsx_sf_settings *settings;
aa03865dcb5ed7 Francesco Lavra 2026-01-19 74 u8 data;
aa03865dcb5ed7 Francesco Lavra 2026-01-19 75 int err;
aa03865dcb5ed7 Francesco Lavra 2026-01-19 76
aa03865dcb5ed7 Francesco Lavra 2026-01-19 77 guard(mutex)(&hw->page_lock);
aa03865dcb5ed7 Francesco Lavra 2026-01-19 78
aa03865dcb5ed7 Francesco Lavra 2026-01-19 79 err = st_lsm6dsx_sf_set_page(hw, true);
aa03865dcb5ed7 Francesco Lavra 2026-01-19 80 if (err < 0)
aa03865dcb5ed7 Francesco Lavra 2026-01-19 81 return err;
aa03865dcb5ed7 Francesco Lavra 2026-01-19 82
aa03865dcb5ed7 Francesco Lavra 2026-01-19 83 settings = &hw->settings->sf_settings;
aa03865dcb5ed7 Francesco Lavra 2026-01-19 84 if (enable) {
aa03865dcb5ed7 Francesco Lavra 2026-01-19 85 u8 odr_val;
aa03865dcb5ed7 Francesco Lavra 2026-01-19 86 const struct st_lsm6dsx_reg *reg = &settings->odr_table.reg;
aa03865dcb5ed7 Francesco Lavra 2026-01-19 87
aa03865dcb5ed7 Francesco Lavra 2026-01-19 88 st_lsm6dsx_sf_get_odr_val(settings, sensor->hwfifo_odr_mHz,
aa03865dcb5ed7 Francesco Lavra 2026-01-19 89 &odr_val);
No error checking on st_lsm6dsx_sf_get_odr_val(). Probably this is
deliberate?
aa03865dcb5ed7 Francesco Lavra 2026-01-19 @90 data = ST_LSM6DSX_SHIFT_VAL(odr_val, reg->mask);
aa03865dcb5ed7 Francesco Lavra 2026-01-19 91 err = regmap_update_bits(hw->regmap, reg->addr, reg->mask,
aa03865dcb5ed7 Francesco Lavra 2026-01-19 92 data);
aa03865dcb5ed7 Francesco Lavra 2026-01-19 93 if (err < 0)
aa03865dcb5ed7 Francesco Lavra 2026-01-19 94 goto out;
aa03865dcb5ed7 Francesco Lavra 2026-01-19 95 }
aa03865dcb5ed7 Francesco Lavra 2026-01-19 96
aa03865dcb5ed7 Francesco Lavra 2026-01-19 97 err = regmap_assign_bits(hw->regmap, settings->fifo_enable.addr,
aa03865dcb5ed7 Francesco Lavra 2026-01-19 98 settings->fifo_enable.mask, enable);
aa03865dcb5ed7 Francesco Lavra 2026-01-19 99 if (err < 0)
aa03865dcb5ed7 Francesco Lavra 2026-01-19 100 goto out;
aa03865dcb5ed7 Francesco Lavra 2026-01-19 101
aa03865dcb5ed7 Francesco Lavra 2026-01-19 102 return st_lsm6dsx_sf_set_page(hw, false);
aa03865dcb5ed7 Francesco Lavra 2026-01-19 103
aa03865dcb5ed7 Francesco Lavra 2026-01-19 104 out:
aa03865dcb5ed7 Francesco Lavra 2026-01-19 105 st_lsm6dsx_sf_set_page(hw, false);
aa03865dcb5ed7 Francesco Lavra 2026-01-19 106
aa03865dcb5ed7 Francesco Lavra 2026-01-19 107 return err;
aa03865dcb5ed7 Francesco Lavra 2026-01-19 108 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2026-01-20 6:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 10:04 [PATCH v3 0/3] imu: st_lsm6dsx: Add support for rotation sensor Francesco Lavra
2026-01-19 10:04 ` [PATCH v3 1/3] iio: imu: st_lsm6dsx: set FIFO ODR for accelerometer and gyroscope only Francesco Lavra
2026-01-19 10:04 ` [PATCH v3 2/3] iio: imu: st_lsm6dsx: set buffer sampling frequency for accelerometer only Francesco Lavra
2026-01-19 10:04 ` [PATCH v3 3/3] iio: imu: st_lsm6dsx: add support for rotation sensor Francesco Lavra
2026-01-19 10:33 ` Andy Shevchenko
2026-01-20 9:28 ` Francesco Lavra
2026-01-20 9:36 ` Andy Shevchenko
2026-01-20 10:03 ` Francesco Lavra
2026-01-20 10:25 ` Andy Shevchenko
2026-01-20 12:23 ` Francesco Lavra
2026-01-20 12:29 ` Andy Shevchenko
2026-01-20 6:46 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202601200451.4BeA8JAe-lkp@intel.com \
--to=dan.carpenter@linaro.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=flavra@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lorenzo@kernel.org \
--cc=nuno.sa@analog.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox