public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	linux-iio@vger.kernel.org, "Andy Shevchenko" <andy@kernel.org>,
	"Sasha Levin" <sashal@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	jorge.marques@analog.com,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Frank Li" <Frank.Li@nxp.com>
Subject: Re: [PATCH] iio: adc: ad4062: Switch from struct i3c_priv_xfer to struct i3c_xfer
Date: Tue, 20 Jan 2026 09:50:41 +0000	[thread overview]
Message-ID: <20260120095041.0000705f@huawei.com> (raw)
In-Reply-To: <aW8sk9mD-dOHeJZg@smile.fi.intel.com>

On Tue, 20 Jan 2026 09:19:47 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Mon, Jan 19, 2026 at 09:36:17PM +0000, Jonathan Cameron wrote:
> 
> > commit 9904232ae30bc ("i3c: drop i3c_priv_xfer and i3c_device_do_priv_xfers()")  
> 
> Commit ?
> The commit ?
> 
> > currently in the i3c/for-next tree removes the deprecated
> > struct i3c_priv_xfer and i3c_device_do_priv_xfers().
> > 
> > Switch to struct i3c_xfer and i3c_device_do_xfers(..., I3C_SDR)
> > now rather causing a build issue when both trees are merged.  
> 
> Not sure if we need a Fixes tag.

I was lazy. Both this and the original patch will go in together
so low risk, but indeed it should have a fixes tag.

> 
> > Suggested-by: Sasha Levin <sashal@kernel.org>
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>  
> 
> > Cc: jorge.marques@analog.com  
> 
> Can we move this to be after the '---' cutter line?

When I really want someone to review / test I tend to put them above the ---
so that I remember to poke them if they don't and I want them to be
included in any follow on threads. 

More FYI type +CC below the line. Mostly I just add them to the send
list however rather than having a Cc at all.

> 
> > ---
> > I'm already carrying this on my tree to resolve the issue in next
> > but feedback still welcome!  
> 
> The rest is fine to me.
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Thanks for the quick response!

J
> 


  reply	other threads:[~2026-01-20  9:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-19 21:36 [PATCH] iio: adc: ad4062: Switch from struct i3c_priv_xfer to struct i3c_xfer Jonathan Cameron
2026-01-20  7:19 ` Andy Shevchenko
2026-01-20  9:50   ` Jonathan Cameron [this message]
2026-01-20 10:03     ` Andy Shevchenko
2026-01-20 21:44       ` Jonathan Cameron
2026-01-20 21:54         ` Jonathan Cameron
2026-01-20 23:09 ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260120095041.0000705f@huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=Frank.Li@nxp.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=jorge.marques@analog.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=sashal@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox