From: Jonathan Cameron <jic23@kernel.org>
To: Shrikant <raskar.shree97@gmail.com>
Cc: "Andy Shevchenko" <andriy.shevchenko@intel.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
skhan@linuxfoundation.org, david.hunter.linux@gmail.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/5] iio: proximity: rfd77402: Reorder header includes
Date: Fri, 23 Jan 2026 09:59:36 +0000 [thread overview]
Message-ID: <20260123095936.27efdeb4@jic23-huawei> (raw)
In-Reply-To: <CAHc1_P6cPk8T1SXK6jmYPsqzqbwM0h6_9eJ82OiRO-uC1Sn+AA@mail.gmail.com>
On Fri, 23 Jan 2026 09:12:31 +0530
Shrikant <raskar.shree97@gmail.com> wrote:
> On Fri, Jan 23, 2026 at 2:27 AM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > On Wed, 21 Jan 2026 10:54:00 +0200
> > Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> >
> > > On Wed, Jan 21, 2026 at 02:05:41AM +0530, Shrikant Raskar via B4 Relay wrote:
> > >
> > > > Reorder header includes to follow kernel include
> > > > ordering conventions.
> > >
> > > FWIW,
> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> > >
> >
> > Patches 1 and 2 were already queued up. I've rebuilt the merge
> > in my tree to drop patch 2 without breaking the rest of the history.
> >
> > Shrikant, it is common for maintainer to pick up the early
> > part of a series whilst later parts still need more work.
> > If that happens, please rebase on the appropriate tree or
> > just drop those patches form your series that have already been
> > applied. Otherwise this mess happens where new review comes
> > in. Review is always good, but it should be clear if it
> > is on applied patches or not!
> >
> Sorry for creating the confusion, the patches 1 and 2 which were
> applied in v4 were dropped from v5 onwards as per your suggestion.
> Please see the links of the accepted patches for your reference.
> 1. https://lore.kernel.org/all/20260101-b4-rfd77402_irq-v4-1-42cd54359e9f@gmail.com/
> 2. https://lore.kernel.org/all/20260101-b4-rfd77402_irq-v4-2-42cd54359e9f@gmail.com/
>
> As per reviewer comments , I have split the existing patches into
> multiple commits like:
> 1. Added pre-cursor commit for include order
> 2. Added separate commit for devm mutex initialization
> 3. Added separate commit for kernel-doc for privata data.
>
> Because of these separated commits, the total number of
> patches in series are still 5.
Ah ok so in general good. I guess you missed that I mailed to say I picked up a few
more in v5.
https://lore.kernel.org/all/20260116200921.7494025b@jic23-huawei/
These things happen so don't worry about it. I was just grumpy last night :(
Feeling much better now I've spent a few more hours getting on top of the
backlog for this cycle!
Jonathan
>
> Regards,
> Shrikant
>
next prev parent reply other threads:[~2026-01-23 9:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 20:35 [PATCH v6 0/5] iio: proximity: Add interrupt support for RFD77402 Shrikant Raskar via B4 Relay
2026-01-20 20:35 ` [PATCH v6 1/5] iio: proximity: rfd77402: Reorder header includes Shrikant Raskar via B4 Relay
2026-01-21 8:54 ` Andy Shevchenko
2026-01-22 20:57 ` Jonathan Cameron
2026-01-23 3:42 ` Shrikant
2026-01-23 9:59 ` Jonathan Cameron [this message]
2026-01-20 20:35 ` [PATCH v6 2/5] iio: proximity: rfd77402: Use kernel helper for result polling Shrikant Raskar via B4 Relay
2026-01-21 9:05 ` Andy Shevchenko
2026-01-24 16:56 ` Shrikant
2026-01-26 9:44 ` Andy Shevchenko
2026-01-26 15:28 ` Shrikant
2026-01-26 16:11 ` Andy Shevchenko
2026-01-20 20:35 ` [PATCH v6 3/5] iio: proximity: rfd77402: Use devm-managed mutex initialization Shrikant Raskar via B4 Relay
2026-01-21 9:16 ` Andy Shevchenko
2026-01-20 20:35 ` [PATCH v6 4/5] iio: proximity: rfd77402: Document device private data structure Shrikant Raskar via B4 Relay
2026-01-21 9:18 ` Andy Shevchenko
2026-01-22 17:42 ` Shrikant
2026-01-20 20:35 ` [PATCH v6 5/5] iio: proximity: rfd77402: Add interrupt handling support Shrikant Raskar via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260123095936.27efdeb4@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=david.hunter.linux@gmail.com \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=raskar.shree97@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox