Re: [PATCH 1/2] iio: magn: mmc5633: Ensure REGMAP_I2C / I3C not build if I2C / I3C is not.

[Jonathan Cameron <jic23@kernel.org>]

On Tue, 20 Jan 2026 09:23:35 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Mon, Jan 19, 2026 at 10:17:35PM +0000, Jonathan Cameron wrote:
> 
> > Fixes the following build warning (and equivalent I2C one)
> > WARNING: unmet direct dependencies detected for REGMAP_I3C
> >   Depends on [n]: I3C [=n]
> >   Selected by [m]:
> >   - MMC5633 [=m] && IIO [=y] && (I2C [=y] || I3C [=n])  
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> 

Unfotunately this isn't sufficient because we get issues
if MMC5633 is built in and I3C is a module.

Not sure why the didn't turn up in 0-day tests until this hit next
(and due to some forgetfulness that was rather late).

Seems this is a common problem as there are some unusual constructs
in tree. I'm going to switch this to

depends on I2C
select REGMAP_I2C
select REGMAP_I3C if I3C
depends on I3C || !I3C

Similar to Guenter did for:
83b645ee43f7 ("hwmon: tmp108: fix I3C dependency)

It is ugly but I'm going to do this as a fix on top of the current tree
as I don't want to rebase just before sending out the pull request.

Jonathan