Re: [PATCH v1 02/10] regulator: cpcap-regulator: add support for Mot regulators

Andy Shevchenko
2026-01-26T10:10:47Z

On Sun, Jan 25, 2026 at 03:42:54PM +0200, Svyatoslav Ryhel wrote:
> Add support for regulator set used in Motorola Mot board, used as a base
> for Atrix 4G and Droid X2 smartphones.

...

> +static const unsigned int sw_mot_val_tbl[] = { 600000, 612500, 625000,
> + 637500, 650000, 662500,
> + 675000, 687500, 700000,
> + 712500, 725000, 737500,
> + 750000, 762500, 775000,
> + 787500, 800000, 812500,
> + 825000, 837500, 850000,
> + 862500, 875000, 887500,
> + 900000, 912500, 925000,
> + 937500, 950000, 962500,
> + 975000, 987500, 1000000,
> + 1012500, 1025000, 1037500,
> + 1050000, 1062500, 1075000,
> + 1087500, 1100000, 1112500,
> + 1125000, 1137500, 1150000,
> + 1162500, 1175000, 1187500,
> + 1200000, 1212500, 1225000,
> + 1237500, 1250000, 1262500,
> + 1275000, 1287500, 1300000,
> + 1312500, 1325000, 1337500,
> + 1350000, 1362500, 1375000,
> + 1387500, 1400000, 1412500,
> + 1425000, 1437500, 1450000,
> + 1462500, 1475000, };

What a style! (Yeah, I see it's being used elsewhere here...)

...

> + CPCAP_REG(VAUDIO, CPCAP_REG_VAUDIOC, CPCAP_REG_ASSIGN4,
> + CPCAP_BIT_VAUDIO_SEL, vaudio_val_tbl,
> + 0x16, 0x1, 0x5, 0, 0),

> + { /* sentinel */ },

No trailing comma for sentinel.

> +};

--
With Best Regards,
Andy Shevchenko