public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Ethan Tidmore <ethantidmore06@gmail.com>
To: linusw@kernel.org, jic23@kernel.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ethan Tidmore <ethantidmore06@gmail.com>
Subject: [PATCH v3 1/4] iio: gyro: mpu3050: Fix incorrect free_irq() variable
Date: Tue, 24 Feb 2026 16:48:15 -0600	[thread overview]
Message-ID: <20260224224818.2452675-2-ethantidmore06@gmail.com> (raw)
In-Reply-To: <20260224224818.2452675-1-ethantidmore06@gmail.com>

The handler for the IRQ part of this driver is mpu3050->trig but,
in the teardown free_irq() is called with handler mpu3050.

Use correct IRQ handler when calling free_irq().

Fixes: 3904b28efb2c7 ("iio: gyro: Add driver for the MPU-3050 gyroscope")
Reviewed-by: Linus Walleij <linusw@kernel.org>
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
---
v3: 
- Remove unneeded code snippet.
v2:
- Patch added to series.

 drivers/iio/gyro/mpu3050-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-core.c
index ee2fcd20545d..06162d886b59 100644
--- a/drivers/iio/gyro/mpu3050-core.c
+++ b/drivers/iio/gyro/mpu3050-core.c
@@ -1261,7 +1261,7 @@ void mpu3050_common_remove(struct device *dev)
 	pm_runtime_disable(dev);
 	iio_triggered_buffer_cleanup(indio_dev);
 	if (mpu3050->irq)
-		free_irq(mpu3050->irq, mpu3050);
+		free_irq(mpu3050->irq, mpu3050->trig);
 	iio_device_unregister(indio_dev);
 	mpu3050_power_down(mpu3050);
 }
-- 
2.53.0


  reply	other threads:[~2026-02-24 22:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24 22:48 [PATCH v3 0/4] iio: gyro: mpu3050: Multiple bug fixes Ethan Tidmore
2026-02-24 22:48 ` Ethan Tidmore [this message]
2026-02-24 22:48 ` [PATCH v3 2/4] iio: gyro: mpu3050: Fix irq resource leak Ethan Tidmore
2026-02-24 22:48 ` [PATCH v3 3/4] iio: gyro: mpu3050: Move iio_device_register() to correct location Ethan Tidmore
2026-02-28 18:17   ` Jonathan Cameron
2026-02-24 22:48 ` [PATCH v3 4/4] iio: gyro: mpu3050: Fix out-of-sequence free_irq() Ethan Tidmore
2026-02-25 11:53   ` Andy Shevchenko
2026-02-25 11:59   ` Andy Shevchenko
2026-02-28 18:15     ` Jonathan Cameron
2026-02-25 12:01 ` [PATCH v3 0/4] iio: gyro: mpu3050: Multiple bug fixes Andy Shevchenko
2026-02-28 18:16   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260224224818.2452675-2-ethantidmore06@gmail.com \
    --to=ethantidmore06@gmail.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox