* [PATCH v2] iio: pressure: abp2030pa: Remove IRQF_ONESHOT from devm_request_irq()
@ 2026-02-27 13:54 Felix Gu
2026-02-28 11:48 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Felix Gu @ 2026-02-27 13:54 UTC (permalink / raw)
To: Petre Rodan, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko
Cc: Jonathan Cameron, Sebastian Andrzej Siewior, linux-iio,
linux-kernel, Felix Gu
Since commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT
without a threaded handler"), the IRQ core checks IRQF_ONESHOT flag
in IRQ request and gives a warning if there is no threaded handler.
Remove IRQF_ONESHOT from devm_request_irq().
Fixes: 47d323ce1e89 ("iio: pressure: add Honeywell ABP2 driver")
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
Changes in v2:
- Fixes Petre's comment.
- Link to v1: https://lore.kernel.org/r/20260227-abp-v1-1-b6fed0545852@gmail.com
---
drivers/iio/pressure/abp2030pa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/pressure/abp2030pa.c b/drivers/iio/pressure/abp2030pa.c
index 4ca056a73cef..b44f1bf4c633 100644
--- a/drivers/iio/pressure/abp2030pa.c
+++ b/drivers/iio/pressure/abp2030pa.c
@@ -520,7 +520,7 @@ int abp2_common_probe(struct device *dev, const struct abp2_ops *ops, int irq)
data->p_offset = div_s64(odelta * data->pmin, pdelta) - data->outmin;
if (data->irq > 0) {
- ret = devm_request_irq(dev, irq, abp2_eoc_handler, IRQF_ONESHOT,
+ ret = devm_request_irq(dev, irq, abp2_eoc_handler, 0,
dev_name(dev), data);
if (ret)
return ret;
---
base-commit: 7d6661873f6b54c75195780a40d66bad3d482d8f
change-id: 20260227-abp-016a007ab817
Best regards,
--
Felix Gu <ustc.gu@gmail.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] iio: pressure: abp2030pa: Remove IRQF_ONESHOT from devm_request_irq()
2026-02-27 13:54 [PATCH v2] iio: pressure: abp2030pa: Remove IRQF_ONESHOT from devm_request_irq() Felix Gu
@ 2026-02-28 11:48 ` Jonathan Cameron
2026-02-28 13:16 ` Petre Rodan
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Cameron @ 2026-02-28 11:48 UTC (permalink / raw)
To: Felix Gu
Cc: Petre Rodan, David Lechner, Nuno Sá, Andy Shevchenko,
Jonathan Cameron, Sebastian Andrzej Siewior, linux-iio,
linux-kernel
On Fri, 27 Feb 2026 21:54:29 +0800
Felix Gu <ustc.gu@gmail.com> wrote:
> Since commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT
> without a threaded handler"), the IRQ core checks IRQF_ONESHOT flag
> in IRQ request and gives a warning if there is no threaded handler.
>
> Remove IRQF_ONESHOT from devm_request_irq().
>
> Fixes: 47d323ce1e89 ("iio: pressure: add Honeywell ABP2 driver")
> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Applied to the fixes-togreg branch of iio.git. If Petre wants to take
another look and perhaps give a tag that would still be welcom.
Thanks!
Jonathan
> ---
> Changes in v2:
> - Fixes Petre's comment.
> - Link to v1: https://lore.kernel.org/r/20260227-abp-v1-1-b6fed0545852@gmail.com
> ---
> drivers/iio/pressure/abp2030pa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/pressure/abp2030pa.c b/drivers/iio/pressure/abp2030pa.c
> index 4ca056a73cef..b44f1bf4c633 100644
> --- a/drivers/iio/pressure/abp2030pa.c
> +++ b/drivers/iio/pressure/abp2030pa.c
> @@ -520,7 +520,7 @@ int abp2_common_probe(struct device *dev, const struct abp2_ops *ops, int irq)
> data->p_offset = div_s64(odelta * data->pmin, pdelta) - data->outmin;
>
> if (data->irq > 0) {
> - ret = devm_request_irq(dev, irq, abp2_eoc_handler, IRQF_ONESHOT,
> + ret = devm_request_irq(dev, irq, abp2_eoc_handler, 0,
> dev_name(dev), data);
> if (ret)
> return ret;
>
> ---
> base-commit: 7d6661873f6b54c75195780a40d66bad3d482d8f
> change-id: 20260227-abp-016a007ab817
>
> Best regards,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] iio: pressure: abp2030pa: Remove IRQF_ONESHOT from devm_request_irq()
2026-02-28 11:48 ` Jonathan Cameron
@ 2026-02-28 13:16 ` Petre Rodan
2026-02-28 13:22 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Petre Rodan @ 2026-02-28 13:16 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Felix Gu, David Lechner, Nuno S??, Andy Shevchenko,
Jonathan Cameron, Sebastian Andrzej Siewior, linux-iio,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2073 bytes --]
hello!
On Sat, Feb 28, 2026 at 11:48:23AM +0000, Jonathan Cameron wrote:
> On Fri, 27 Feb 2026 21:54:29 +0800
> Felix Gu <ustc.gu@gmail.com> wrote:
>
> > Since commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT
> > without a threaded handler"), the IRQ core checks IRQF_ONESHOT flag
> > in IRQ request and gives a warning if there is no threaded handler.
> >
> > Remove IRQF_ONESHOT from devm_request_irq().
> >
> > Fixes: 47d323ce1e89 ("iio: pressure: add Honeywell ABP2 driver")
> > Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > Signed-off-by: Felix Gu <ustc.gu@gmail.com>
>
> Applied to the fixes-togreg branch of iio.git. If Petre wants to take
> another look and perhaps give a tag that would still be welcom.
thank you for the patch, Felix.
took me a hot minute to upgrade everything to 7.0.0, you were both too fast :)
Tested-by: Petre Rodan <petre.rodan@subdimension.ro>
best regards,
peter
>
> Thanks!
>
> Jonathan
>
> > ---
> > Changes in v2:
> > - Fixes Petre's comment.
> > - Link to v1: https://lore.kernel.org/r/20260227-abp-v1-1-b6fed0545852@gmail.com
> > ---
> > drivers/iio/pressure/abp2030pa.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/pressure/abp2030pa.c b/drivers/iio/pressure/abp2030pa.c
> > index 4ca056a73cef..b44f1bf4c633 100644
> > --- a/drivers/iio/pressure/abp2030pa.c
> > +++ b/drivers/iio/pressure/abp2030pa.c
> > @@ -520,7 +520,7 @@ int abp2_common_probe(struct device *dev, const struct abp2_ops *ops, int irq)
> > data->p_offset = div_s64(odelta * data->pmin, pdelta) - data->outmin;
> >
> > if (data->irq > 0) {
> > - ret = devm_request_irq(dev, irq, abp2_eoc_handler, IRQF_ONESHOT,
> > + ret = devm_request_irq(dev, irq, abp2_eoc_handler, 0,
> > dev_name(dev), data);
> > if (ret)
> > return ret;
> >
> > ---
> > base-commit: 7d6661873f6b54c75195780a40d66bad3d482d8f
> > change-id: 20260227-abp-016a007ab817
> >
> > Best regards,
>
--
petre rodan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 870 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] iio: pressure: abp2030pa: Remove IRQF_ONESHOT from devm_request_irq()
2026-02-28 13:16 ` Petre Rodan
@ 2026-02-28 13:22 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2026-02-28 13:22 UTC (permalink / raw)
To: Petre Rodan
Cc: Felix Gu, David Lechner, Nuno S??, Andy Shevchenko,
Jonathan Cameron, Sebastian Andrzej Siewior, linux-iio,
linux-kernel
On Sat, 28 Feb 2026 15:16:32 +0200
Petre Rodan <petre.rodan@subdimension.ro> wrote:
> hello!
>
> On Sat, Feb 28, 2026 at 11:48:23AM +0000, Jonathan Cameron wrote:
> > On Fri, 27 Feb 2026 21:54:29 +0800
> > Felix Gu <ustc.gu@gmail.com> wrote:
> >
> > > Since commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT
> > > without a threaded handler"), the IRQ core checks IRQF_ONESHOT flag
> > > in IRQ request and gives a warning if there is no threaded handler.
> > >
> > > Remove IRQF_ONESHOT from devm_request_irq().
> > >
> > > Fixes: 47d323ce1e89 ("iio: pressure: add Honeywell ABP2 driver")
> > > Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > > Signed-off-by: Felix Gu <ustc.gu@gmail.com>
> >
> > Applied to the fixes-togreg branch of iio.git. If Petre wants to take
> > another look and perhaps give a tag that would still be welcom.
>
> thank you for the patch, Felix.
> took me a hot minute to upgrade everything to 7.0.0, you were both too fast :)
>
> Tested-by: Petre Rodan <petre.rodan@subdimension.ro>
Thanks Petre!
Added the tag.
Jonathan
>
> best regards,
> peter
>
> >
> > Thanks!
> >
> > Jonathan
> >
> > > ---
> > > Changes in v2:
> > > - Fixes Petre's comment.
> > > - Link to v1: https://lore.kernel.org/r/20260227-abp-v1-1-b6fed0545852@gmail.com
> > > ---
> > > drivers/iio/pressure/abp2030pa.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/iio/pressure/abp2030pa.c b/drivers/iio/pressure/abp2030pa.c
> > > index 4ca056a73cef..b44f1bf4c633 100644
> > > --- a/drivers/iio/pressure/abp2030pa.c
> > > +++ b/drivers/iio/pressure/abp2030pa.c
> > > @@ -520,7 +520,7 @@ int abp2_common_probe(struct device *dev, const struct abp2_ops *ops, int irq)
> > > data->p_offset = div_s64(odelta * data->pmin, pdelta) - data->outmin;
> > >
> > > if (data->irq > 0) {
> > > - ret = devm_request_irq(dev, irq, abp2_eoc_handler, IRQF_ONESHOT,
> > > + ret = devm_request_irq(dev, irq, abp2_eoc_handler, 0,
> > > dev_name(dev), data);
> > > if (ret)
> > > return ret;
> > >
> > > ---
> > > base-commit: 7d6661873f6b54c75195780a40d66bad3d482d8f
> > > change-id: 20260227-abp-016a007ab817
> > >
> > > Best regards,
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-28 13:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-27 13:54 [PATCH v2] iio: pressure: abp2030pa: Remove IRQF_ONESHOT from devm_request_irq() Felix Gu
2026-02-28 11:48 ` Jonathan Cameron
2026-02-28 13:16 ` Petre Rodan
2026-02-28 13:22 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox