From: Ethan Tidmore <ethantidmore06@gmail.com>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Ethan Tidmore" <ethantidmore06@gmail.com>
Subject: [PATCH 3/3] iio: filter: admv8818: Minor cleanups
Date: Fri, 27 Feb 2026 00:14:24 -0600 [thread overview]
Message-ID: <20260227061424.1135505-4-ethantidmore06@gmail.com> (raw)
In-Reply-To: <20260227061424.1135505-1-ethantidmore06@gmail.com>
Resolve every checkpatch error in the driver.
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
---
drivers/iio/filter/admv8818.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/filter/admv8818.c b/drivers/iio/filter/admv8818.c
index 2d12700d717f..1af263007322 100644
--- a/drivers/iio/filter/admv8818.c
+++ b/drivers/iio/filter/admv8818.c
@@ -240,7 +240,6 @@ static int __admv8818_lpf_select(struct admv8818_state *st, u64 freq)
freq_step = div_u64(freq_step, ADMV8818_NUM_STATES - 1);
for (state = ADMV8818_STATE_MAX; state >= ADMV8818_STATE_MIN; --state) {
-
freq_corner = freq_range_lpf[band][ADMV8818_BAND_CORNER_LOW] +
state * freq_step;
@@ -385,8 +384,8 @@ static int admv8818_read_lpf_freq(struct admv8818_state *st, u64 *lpf_freq)
}
static int admv8818_write_raw_get_fmt(struct iio_dev *indio_dev,
- struct iio_chan_spec const *chan,
- long mask)
+ struct iio_chan_spec const *chan,
+ long mask)
{
switch (mask) {
case IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY:
@@ -722,7 +721,6 @@ static int admv8818_read_properties(struct admv8818_state *st)
else
return ret;
-
ret = device_property_read_u32(&spi->dev, "adi,hpf-margin-mhz", &mhz);
if (ret == 0)
st->hpf_margin_hz = (u64)mhz * HZ_PER_MHZ;
--
2.53.0
next prev parent reply other threads:[~2026-02-27 6:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 6:14 [PATCH 0/3] iio: filter: admv8818: Bug fix and other improvements Ethan Tidmore
2026-02-27 6:14 ` [PATCH 1/3] iio: filter: admv8818: Add missing error code Ethan Tidmore
2026-02-27 6:42 ` Ethan Tidmore
2026-02-27 7:06 ` Andy Shevchenko
2026-02-27 16:01 ` David Lechner
2026-02-27 16:06 ` Andy Shevchenko
2026-02-27 7:04 ` Andy Shevchenko
2026-02-27 16:02 ` David Lechner
2026-02-27 6:14 ` [PATCH 2/3] iio: filter: admv8818: Simplify locking with guard() Ethan Tidmore
2026-02-27 7:08 ` Andy Shevchenko
2026-02-27 16:08 ` David Lechner
2026-03-02 22:34 ` Ethan Tidmore
2026-02-27 6:14 ` Ethan Tidmore [this message]
2026-02-27 7:18 ` [PATCH 3/3] iio: filter: admv8818: Minor cleanups Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260227061424.1135505-4-ethantidmore06@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox