public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: junan <junan76@163.com>
To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
	andy@kernel.org, sakari.ailus@linux.intel.com
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	junan <junan76@163.com>
Subject: [PATCH] Replace NULL thread handler with a dummy function.
Date: Sat, 28 Feb 2026 10:36:46 +0800	[thread overview]
Message-ID: <20260228023643.12000-4-junan76@163.com> (raw)

Hi,

This is a similar problem as [1]:

[1] https://lore.kernel.org/linux-iio/20260227071409.aEG-iBFD@linutronix.de/T/#m15ab81856b42f72169fe51bd87fa399b5147441f

Since commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT
without a threaded handler"), the IRQ core checks IRQF_ONESHOT flag
in IRQ request and gives a warning if there is no threaded handler.

There are two iio devices on my machine:

```
junan@fedora:~$ ls /sys/bus/iio/devices/
iio:device0  trigger0
junan@fedora:~$ cat /sys/bus/iio/devices/*/name
als
als-dev0
```

The function calling chain is as following:

hid_als_probe(hid-sensor-als.c)
	=> hid_sensor_setup_trigger(hid-sensor-trigger.c)
		=> iio_triggered_buffer_setup_ext(industrialio-triggered-buffer.c)

`iio_triggered_buffer_setup_ext` is called with a NULL thread handler, and the flag is set to `IRQF_ONESHOT` inside it.
I am not sure which flag to change, so I replace the NULL pointer with a dummy function or can we just change the flag?

Signed-off-by: junan <junan76@163.com>
---
 drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
index 5540e2d28f4a..ec251beeca92 100644
--- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
+++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
@@ -202,6 +202,11 @@ static void hid_sensor_set_power_work(struct work_struct *work)
 		_hid_sensor_power_state(attrb, true);
 }
 
+static irqreturn_t hid_sensor_dummy_handler(int irq, void *p)
+{
+	return IRQ_HANDLED;
+}
+
 static int hid_sensor_data_rdy_trigger_set_state(struct iio_trigger *trig,
 						bool state)
 {
@@ -240,7 +245,7 @@ int hid_sensor_setup_trigger(struct iio_dev *indio_dev, const char *name,
 		fifo_attrs = NULL;
 
 	ret = iio_triggered_buffer_setup_ext(indio_dev,
-					     &iio_pollfunc_store_time, NULL,
+					     &iio_pollfunc_store_time, &hid_sensor_dummy_handler,
 					     IIO_BUFFER_DIRECTION_IN,
 					     NULL, fifo_attrs);
 	if (ret) {
-- 
2.53.0


             reply	other threads:[~2026-02-28  3:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-28  2:36 junan [this message]
2026-02-28 10:15 ` [PATCH] Replace NULL thread handler with a dummy function Andy Shevchenko
2026-02-28 11:21   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260228023643.12000-4-junan76@163.com \
    --to=junan76@163.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox