public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Antoniu Miclaus" <antoniu.miclaus@analog.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ade9000: move mutex init before IRQ registration
Date: Sat, 28 Feb 2026 11:52:26 +0000	[thread overview]
Message-ID: <20260228115226.1199526d@jic23-huawei> (raw)
In-Reply-To: <aaLL7qHSQWMzwadp@ashevche-desk.local>

On Sat, 28 Feb 2026 13:05:18 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Fri, Feb 27, 2026 at 03:33:30PM +0200, Antoniu Miclaus wrote:
> > Move devm_mutex_init() before ade9000_request_irq() calls so that
> > st->lock is initialized before any handler that depends on it can run.  
> 
> Sounds good. The technique to reproduce this (in case you have a HWr
> to make sure probe runs) the kernel configuration should have
> CONFIG_DEBUG_SHIRQ=y (and in some cases a tweak in the code to flag
> IRQ as shared).
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> 
Applied as a fix, so I added a Fixes tag and +CC stable.

Whilst hard to hit it is is always good to ensure we are safe against
spurious interrupts.

thanks,

Jonathan



      reply	other threads:[~2026-02-28 11:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27 13:33 [PATCH] iio: adc: ade9000: move mutex init before IRQ registration Antoniu Miclaus
2026-02-28 11:05 ` Andy Shevchenko
2026-02-28 11:52   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260228115226.1199526d@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=antoniu.miclaus@analog.com \
    --cc=dlechner@baylibre.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox