From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] iio: frequency: ad9523: use dev_err_probe
Date: Sat, 7 Mar 2026 11:09:39 +0000 [thread overview]
Message-ID: <20260307110939.7fbfe548@jic23-huawei> (raw)
In-Reply-To: <aarHeQbq-Ml-ZjqR@ashevche-desk.local>
On Fri, 6 Mar 2026 14:24:25 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Fri, Mar 06, 2026 at 12:24:48PM +0200, Antoniu Miclaus wrote:
> > Use dev_err_probe() instead of dev_err() in the probe path to ensure
> > proper handling of deferred probing and to simplify error handling.
>
> ...
>
> > - if (!pdata) {
> > - dev_err(dev, "no platform data?\n");
> > - return -EINVAL;
> > - }
> > + if (!pdata)
> > + return dev_err_probe(dev, -EINVAL, "no platform data?\n");
>
> Platform data?! Maybe we can get rid of it entirely?
Good thing to do, but big job. There is no DT binding for this and
the platform data is very complex. I checked though and the part is
still recommended for new designs so if Analog wants to support it going
forward that work needs doing.
Jonathan
>
next prev parent reply other threads:[~2026-03-07 11:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 10:24 [PATCH 0/4] iio: frequency: use dev_err_probe for admv4420 and ad9523 Antoniu Miclaus
2026-03-06 10:24 ` [PATCH 1/4] iio: frequency: admv4420: add dev variable Antoniu Miclaus
2026-03-06 14:41 ` Andy Shevchenko
2026-03-06 10:24 ` [PATCH 2/4] iio: frequency: admv4420: use dev_err_probe Antoniu Miclaus
2026-03-06 14:45 ` Andy Shevchenko
2026-03-06 10:24 ` [PATCH 3/4] iio: frequency: ad9523: add dev variable Antoniu Miclaus
2026-03-06 14:39 ` Andy Shevchenko
2026-03-06 10:24 ` [PATCH 4/4] iio: frequency: ad9523: use dev_err_probe Antoniu Miclaus
2026-03-06 12:24 ` Andy Shevchenko
2026-03-07 11:09 ` Jonathan Cameron [this message]
2026-03-06 12:24 ` [PATCH 0/4] iio: frequency: use dev_err_probe for admv4420 and ad9523 Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260307110939.7fbfe548@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox