From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Chunyang Chen <chenchunyang0908@gmail.com>,
kuurtb@gmail.com, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: adc: ti-ads1018: fix type overflow for data rate
Date: Sat, 7 Mar 2026 12:15:30 +0000 [thread overview]
Message-ID: <20260307121530.370dd3db@jic23-huawei> (raw)
In-Reply-To: <aarDrwAITxtS1ziI@ashevche-desk.local>
On Fri, 6 Mar 2026 14:08:15 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Thu, Mar 05, 2026 at 08:43:02PM +0800, Chunyang Chen wrote:
> > The variable 'drate' is currently defined as u8. However, the data rate
> > values in ads1018 can reach up to 3300 Hz, which exceeds the maximum
> > value of 255 that a u8 can hold.
> >
> > Change the type of 'drate' to u32 to match the data_rate_mode_to_hz
> > array definition and ensure the data rate is handled correctly.
> >
> > Fixes: bf0bba486b5b ("iio: adc: ti-ads1018: add ti-ads1018 driver")
> > Signed-off-by: Chunyang Chen <chenchunyang0908@gmail.com>
>
> New version — new email thread.
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
Applied to the fixes-togreg branch of iio.git
Thanks,
Jonathan
next prev parent reply other threads:[~2026-03-07 12:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 2:15 [PATCH] iio: adc: ti-ads1018: fix type overflow for data rate Chunyang Chen
2026-03-05 2:36 ` Kurt Borja
2026-03-05 7:07 ` Andy Shevchenko
2026-03-05 12:46 ` Chunyang Chen
2026-03-05 12:43 ` [PATCH v2] " Chunyang Chen
2026-03-05 13:12 ` Kurt Borja
2026-03-06 12:08 ` Andy Shevchenko
2026-03-07 12:15 ` Jonathan Cameron [this message]
2026-03-07 13:18 ` Jonathan Cameron
2026-03-09 3:20 ` Chunyang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260307121530.370dd3db@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=chenchunyang0908@gmail.com \
--cc=dlechner@baylibre.com \
--cc=kuurtb@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox