From: Archit Anant <architanant5@gmail.com>
To: jic23@kernel.org, dlechner@baylibre.com
Cc: lars@metafoo.de, Michael.Hennerich@analog.com,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Archit Anant <architanant5@gmail.com>,
Andy Shevchenko <andriy.shevchenko@intel.com>
Subject: [PATCH v4 4/4] iio: adc: ad799x: use devm_iio_device_register and drop remove
Date: Sun, 8 Mar 2026 23:58:11 +0530 [thread overview]
Message-ID: <20260308182811.33471-5-architanant5@gmail.com> (raw)
In-Reply-To: <20260308182811.33471-1-architanant5@gmail.com>
Convert the driver to use the device-managed versions of
iio_device_register(), iio_triggered_buffer_setup(), and
devm_mutex_init().
By moving these remaining resources to the devm framework, the
driver no longer requires manual cleanup. This allows for the removal
of all remaining goto labels in ad799x_probe() and the complete
deletion of the ad799x_remove() function.
Suggested-by: David Lechner <dlechner@baylibre.com>
Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Archit Anant <architanant5@gmail.com>
---
drivers/iio/adc/ad799x.c | 27 +++++----------------------
1 file changed, 5 insertions(+), 22 deletions(-)
diff --git a/drivers/iio/adc/ad799x.c b/drivers/iio/adc/ad799x.c
index f5ef6ff97c89..89ac0d393366 100644
--- a/drivers/iio/adc/ad799x.c
+++ b/drivers/iio/adc/ad799x.c
@@ -861,7 +861,7 @@ static int ad799x_probe(struct i2c_client *client)
if (ret)
return ret;
- ret = iio_triggered_buffer_setup(indio_dev, NULL,
+ ret = devm_iio_triggered_buffer_setup(dev, indio_dev, NULL,
&ad799x_trigger_handler, NULL);
if (ret)
return ret;
@@ -876,30 +876,14 @@ static int ad799x_probe(struct i2c_client *client)
client->name,
indio_dev);
if (ret)
- goto error_cleanup_ring;
+ return ret;
}
- mutex_init(&st->lock);
-
- ret = iio_device_register(indio_dev);
+ ret = devm_mutex_init(dev, &st->lock);
if (ret)
- goto error_cleanup_ring;
-
- return 0;
-
-error_cleanup_ring:
- iio_triggered_buffer_cleanup(indio_dev);
-
- return ret;
-}
-
-static void ad799x_remove(struct i2c_client *client)
-{
- struct iio_dev *indio_dev = i2c_get_clientdata(client);
-
- iio_device_unregister(indio_dev);
+ return ret;
- iio_triggered_buffer_cleanup(indio_dev);
+ return devm_iio_device_register(dev, indio_dev);
}
static int ad799x_suspend(struct device *dev)
@@ -969,7 +953,6 @@ static struct i2c_driver ad799x_driver = {
.pm = pm_sleep_ptr(&ad799x_pm_ops),
},
.probe = ad799x_probe,
- .remove = ad799x_remove,
.id_table = ad799x_id,
};
module_i2c_driver(ad799x_driver);
--
2.39.5
prev parent reply other threads:[~2026-03-08 18:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 18:28 [PATCH v4 0/4] iio: adc: ad799x: modernize resource management Archit Anant
2026-03-08 18:28 ` [PATCH v4 1/4] iio: adc: ad799x: make rx_buf static Archit Anant
2026-03-08 21:10 ` Andy Shevchenko
2026-03-08 18:28 ` [PATCH v4 2/4] iio: adc: ad799x: cache regulator voltage during probe Archit Anant
2026-03-08 21:12 ` Andy Shevchenko
2026-03-09 19:38 ` Jonathan Cameron
2026-03-08 18:28 ` [PATCH v4 3/4] iio: adc: ad799x: use devm_add_action_or_reset for regulators Archit Anant
2026-03-08 21:15 ` Andy Shevchenko
2026-03-08 18:28 ` Archit Anant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260308182811.33471-5-architanant5@gmail.com \
--to=architanant5@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox