From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Rajveer Chaudhari <rajveer.chaudhari.linux@gmail.com>,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
waqar.hameed@axis.com, linusw@kernel.org,
sakari.ailus@linux.intel.com, harshit.m.mogalapalli@oracle.com,
antoniu.miclaus@analog.com, andrew.ijano@gmail.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] iio: accel: bmc150: convert to guard(mutex)
Date: Mon, 9 Mar 2026 19:15:04 +0000 [thread overview]
Message-ID: <20260309191504.616a9bd3@jic23-huawei> (raw)
In-Reply-To: <aa71SqlaSrXdpl89@ashevche-desk.local>
On Mon, 9 Mar 2026 18:28:58 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Mon, Mar 09, 2026 at 09:04:05PM +0530, Rajveer Chaudhari wrote:
> > Replace manual mutex_lock/mutex_unlock pair with guard(mutex) in
> > bmc150_accel_buffer_predisable() and
> > bmc150_accel_buffer_postenable(). This ensures the mutex is
> > released on all return paths and allows returning directly
> > without a goto label.
>
> Wait _at least_ 24h between the versions of the patch or patch series.
> Let others give a chance to comment, review, et cetera!
>
> So, based on the discussion in v1 it might make sense to have a sorting patches
> as precursor for each of the drivers in question. But since it's indeed cosmetic
> change I leave it to maintainers and other reviewers to judge.
Given the code is being 'touched' anyway, I'd welcome precursor patches
sorting the headers prior to adding a new one.
Not something I'll insist on though.
Thanks,
Jonathan
>
next prev parent reply other threads:[~2026-03-09 19:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 15:34 [PATCH v2 0/4] iio: accel: convert to guard(mutex) Rajveer Chaudhari
2026-03-09 15:34 ` [PATCH v2 1/4] iio: accel: bmc150: " Rajveer Chaudhari
2026-03-09 16:28 ` Andy Shevchenko
2026-03-09 19:15 ` Jonathan Cameron [this message]
2026-03-09 19:13 ` Jonathan Cameron
2026-03-09 15:34 ` [PATCH v2 2/4] iio: accel: mma8452: " Rajveer Chaudhari
2026-03-09 15:34 ` [PATCH v2 3/4] iio: accel: mma9551: " Rajveer Chaudhari
2026-03-09 15:34 ` [PATCH v2 4/4] iio: accel: sca3000: " Rajveer Chaudhari
2026-03-09 19:30 ` Jonathan Cameron
2026-03-09 19:58 ` Rajveer Chaudhari
2026-03-09 20:03 ` David Lechner
2026-03-09 20:06 ` Rajveer Chaudhari
2026-03-09 16:30 ` [PATCH v2 0/4] iio: accel: " Andy Shevchenko
2026-03-09 17:33 ` Rajveer Chaudhari
2026-03-09 17:57 ` Waqar Hameed
2026-03-09 18:15 ` Rajveer Chaudhari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260309191504.616a9bd3@jic23-huawei \
--to=jic23@kernel.org \
--cc=andrew.ijano@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=linusw@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=rajveer.chaudhari.linux@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=waqar.hameed@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox