Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Matt Ranostay" <mranostay@gmail.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: adc: ti-adc161s626: use DMA-safe memory for spi_read()
Date: Sat, 21 Mar 2026 20:45:06 +0000	[thread overview]
Message-ID: <20260321204506.4b5df02a@jic23-huawei> (raw)
In-Reply-To: <abgOH5Zo6J9m8qiW@ashevche-desk.local>

On Mon, 16 Mar 2026 16:05:19 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Sat, Mar 14, 2026 at 06:13:32PM -0500, David Lechner wrote:
> > Add a DMA-safe buffer and use it for spi_read() instead of a stack
> > memory. All SPI buffers must be DMA-safe.
> > 
> > Since we only need up to 3 bytes, we just use a u8[] instead of __be16
> > and __be32 and change the conversion functions appropriately.  
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> 

Applied and marked for stable with the following as amazingly enough I was
running a config where it didn't have this via another path so the build
failed.

Thanks,

J

diff --git a/drivers/iio/adc/ti-adc161s626.c b/drivers/iio/adc/ti-adc161s626.c
index 833a636a29bb..be1cc2e77862 100644
--- a/drivers/iio/adc/ti-adc161s626.c
+++ b/drivers/iio/adc/ti-adc161s626.c
@@ -15,6 +15,7 @@
 #include <linux/init.h>
 #include <linux/err.h>
 #include <linux/spi/spi.h>
+#include <linux/unaligned.h>
 #include <linux/iio/iio.h>
 #include <linux/iio/trigger.h>
 #include <linux/iio/buffer.h>

  reply	other threads:[~2026-03-21 20:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-14 23:13 [PATCH 0/2] iio: adc: ti-adc161s626: fix scan buffer handling David Lechner
2026-03-14 23:13 ` [PATCH 1/2] iio: adc: ti-adc161s626: fix buffer read on big-endian David Lechner
2026-03-16 13:56   ` Andy Shevchenko
2026-03-21 20:42     ` Jonathan Cameron
2026-03-14 23:13 ` [PATCH 2/2] iio: adc: ti-adc161s626: use DMA-safe memory for spi_read() David Lechner
2026-03-16 14:05   ` Andy Shevchenko
2026-03-21 20:45     ` Jonathan Cameron [this message]
2026-03-16 18:31   ` Jonathan Cameron
2026-03-16 19:53     ` Andy Shevchenko
2026-03-21 19:40       ` David Lechner
2026-03-21 20:54         ` Jonathan Cameron
2026-03-21 20:18       ` Jonathan Cameron
2026-03-21 19:27     ` David Lechner
2026-03-21 20:21       ` Jonathan Cameron
2026-03-27  9:13   ` kernel test robot
2026-03-27  9:44     ` Andy Shevchenko
2026-03-27 13:54       ` David Lechner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260321204506.4b5df02a@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mranostay@gmail.com \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox